Templates not handled well in title blacklist messages
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Awesome_Aasim
	Nov 1 2023, 6:35 PM

Description

Steps to replicate the issue (include links if applicable):

I initiate an edit, move, or creation that triggers the title blacklist.

What happens?:

The message is displayed but the regex cuts off the template.

What should have happened instead?:

MediaWiki should have escaped the pipe and equal signs when passing the regex, resulting in the full message being displayed.

Please also see https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_184#Escaping_a_pipe_character_in_system_messages. I was going to do a Lua module to work around this, but after reading the documentation, Lua does not preserve parameter order.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

	Subject	Repo	Branch	Lines +/-
	Escape raw title blacklist entry for wikitext when used in messages	mediawiki/extensions/TitleBlacklist	master	+3 -3

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2023, 6:35 PM

The messages are:

For the edit message the template was removed in 2020 with https://en.wikipedia.org/w/index.php?title=MediaWiki:Titleblacklist-forbidden-edit&diff=prev&oldid=978215529.
It is also using nowiki around $1 to prevent some links to get parsed.

Change 971307 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TitleBlacklist@master] Escape raw title blacklist entry for wikitext when used in messages

Change 971307 merged by jenkins-bot:

[mediawiki/extensions/TitleBlacklist@master] Escape raw title blacklist entry for wikitext when used in messages

Umherirrender claimed this task.