Page MenuHomePhabricator

Remove dead SpecialPages_reorderPages hook from Wikibase
Closed, ResolvedPublic

Description

@jeblad: This seems like a problem:

So in essence, Wikibase Repo has code listening for the hook callback SpecialPage_reorderPages that has never existed in Mediawiki core so is never called! Can we get rid of this useless code (or get the hook caller created so the code is not useless)? And this has been like this for over six years now.

Thanks

Event Timeline

ItamarWMDE subscribed.

Tagging Wikibase Product Platform Team WPP, as this relates to part of Wikibase Repo that might be relevant to them.

Change #1039808 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Wikibase@master] Remove SpecialPage_ReorderPages hook

https://gerrit.wikimedia.org/r/1039808

Change #1039808 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove SpecialPage_ReorderPages hook

https://gerrit.wikimedia.org/r/1039808

Pppery removed a project: Patch-For-Review.