Page MenuHomePhabricator
Create Task
Maniphest T350632

Argument 2 passed to MediaWiki\Page\File\BadFileLookup::isBadFile() must implement interface MediaWiki\Linker\LinkTarget or be null, bool given
Closed, ResolvedPublic
Actions

Description

We ran into this error in T315510. Very rare, 3 hits in last 90 days: https://logstash.wikimedia.org/goto/a5b8b65caec2f3b88dcd8550b0df6670

Details

SubjectRepoBranchLines +/-
Parsoid\Config\DataAccess: Fix type of param to BadFileLookup::isBadFile()mediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Nov 6 2023, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2023, 10:23 PM
matmarex claimed this task.Nov 6 2023, 10:29 PM
gerritbot added a comment.Nov 6 2023, 10:29 PM

Change 972057 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Parsoid\Config\DataAccess: Fix type of param to BadFileLookup::isBadFile()

https://gerrit.wikimedia.org/r/972057

gerritbot added a project: Patch-For-Review.Nov 6 2023, 10:29 PM
gerritbot added a comment.Nov 12 2023, 5:22 PM

Change 972057 merged by jenkins-bot:

[mediawiki/core@master] Parsoid\Config\DataAccess: Fix type of param to BadFileLookup::isBadFile()

https://gerrit.wikimedia.org/r/972057

Maintenance_bot removed a project: Patch-For-Review.Nov 12 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 12 2023, 6:00 PM
matmarex closed this task as Resolved.Nov 13 2023, 4:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL