Page MenuHomePhabricator
Create Task
Maniphest T350934

[BUG] Wikibase LocalMedia use of deprecated function in MW 1.40
Closed, ResolvedPublicBUG REPORT
Actions

Description

When loading an item page with an item having an image attached, the WikibaseLocalMedia extension causes the display of a deprecation warning.

screenshot-20231110113825.png (344×1 px, 106 KB)

Use of Language::factory was deprecated in MediaWiki 1.35. [Called from Wikibase\LocalMedia\Services\InlineImageFormatter::__construct in /var/www/html/extensions/WikibaseLocalMedia/src/Services/InlineImageFormatter.php at line 68]

To reproduce, browse the item revision history back and forth between revisions with and without image. This probably flushes some cache. The deprecation warning is not visible on simple page (re-)loads as soon as the page has been rendered once.

Related Objects
Search...

Event Timeline

roti_WMDE created this task.Nov 10 2023, 10:41 AM
Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptNov 10 2023, 10:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
roti_WMDE added a parent task: T340939: wmde.14 (1.40.1) major release.Nov 10 2023, 10:41 AM
roti_WMDE added a comment.Nov 10 2023, 11:17 AM

upstream PR https://github.com/ProfessionalWiki/WikibaseLocalMedia/pull/28

roti_WMDE claimed this task.Nov 10 2023, 11:17 AM
roti_WMDE moved this task from To do (prio from top to bottom) to In Review on the Wikibase Suite Team (Sprint-∞) board.
roti_WMDE updated the task description. (Show Details)Nov 10 2023, 11:23 AM
roti_WMDE mentioned this in T351058: Check for MediaWiki/PHP (deprecation) warnings/errors on pages.Nov 13 2023, 8:19 AM
roti_WMDE mentioned this in T340939: wmde.14 (1.40.1) major release.Nov 13 2023, 8:29 AM
roti_WMDE closed this task as Resolved.Nov 15 2023, 7:01 AM
roti_WMDE moved this task from In Review to Done on the Wikibase Suite Team (Sprint-∞) board.
darthmon_wmde moved this task from Sprint-∞ to Archive (closed) on the Wikibase Suite Team board.Nov 21 2023, 2:15 PM
darthmon_wmde edited projects, added Wikibase Suite Team; removed Wikibase Suite Team (Sprint-∞).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits