Page MenuHomePhabricator

Trigger upload ghcr github action workflow on prep-mw- branches as well
Closed, ResolvedPublic

Description

Current Situation:

  • Currently, CI runs on main and mw- branches push built images to the Github container registry (GHCR). Those images are used for internal testing only, our public facing container registry is docker hub.

Goal:

  • It is handy to test images built on prep-mw- branches as well. Extend the GHCR upload to prep-mw- branches.

Acceptance Criteria:

  • prep-mw- branches upload to GHCR as well

[optional] Notes:

  • This allows us to test release prep builds where ever we want without complicated github actifact downloads. We just change the image names in our docker-compose files to ghcr.io/wmde/wikibase:6851356975 (the number is the github actions ci run number)
  • THIS MAKES prep-mw- BRANCHES SPECIAL. WE WANT TO NAME RELEASE PREP BRANCHES LIKE THAT UNTIL WE COME UP WITH ANOTHER SCHEME

[optional] Open Questions:

  • Should we move all docker container registry uploads to docker hub eventually?
  • How do we tag prerelease builds on docker hub to not clutter our tags page?

Event Timeline

roti_WMDE renamed this task from Manual trigger upload ghcr github action workflow to Trigger upload ghcr github action workflow on prep-mw- branches as well.Nov 15 2023, 11:28 AM
roti_WMDE updated the task description. (Show Details)
roti_WMDE changed the task status from Open to In Progress.Nov 17 2023, 11:32 AM
roti_WMDE moved this task from In Review to Doing on the Wikibase Suite Team (Sprint-∞) board.

The new rule is that main, mw- branches and all branches merging into mw- branches will have their builds uploaded to GHCR. So there is no need to apply specific naming to branches merging to release branches. The only hardcoded names are main and mw-.