Page MenuHomePhabricator

Implement a new notification only revision-visibility-change stream
Open, Needs TriagePublic

Description

mediawiki.revision.visibility-change currently exposes data that we would rather not expose anymore because it duplicates logic that may get us in trouble again in the future.

In this task, we should:

  • Deprecate the current mediawiki.revision.visibility-change stream
  • Implement a new notification only stream that should expose the following:

database,
rev_id,
rev_timestamp,
visibility struct,
prior_state struct

  • Perhaps take the opportunity to check the above and make sure the field names agree between newer revision streams? (i.e. database vs wiki_id)

(See T349845 for further details)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Here is the code currently creating and emitting revision-visibility-change.

EventBusHooks is deprecated. We should add a new hook handler in https://github.com/wikimedia/mediawiki-extensions-EventBus/tree/master/includes/HookHandlers/MediaWiki for this. HookHandlers/MediaWiki/RevisionChangeHooks.php maybe!

In today's 'Dumps 2.0 Architecture Discussions' meeting, we decided that:

  • This mechanism should not block Dumps 2.0 moving forward.
  • In the event that this mechanism is available, we will deprecate our use of the current mediawiki.revision.visibility-change stream in favor of this new stream. Given we do not consume any other fields than the ones mentioned in this ticket, we do not foresee any compatibility issues.