Page MenuHomePhabricator

ipip-multiqueue-optimizer should unload eBPF programs on service stop
Closed, ResolvedPublic

Description

current behavior:

vgutierrez@lvs4010:~$ sudo -i bpftool prog |grep ipip
23092: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl
23093: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl
vgutierrez@lvs4010:~$ sudo -i systemctl stop ipip-multiqueue-optimizer.service 
vgutierrez@lvs4010:~$ sudo -i bpftool prog |grep ipip
23092: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl
23093: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl

Details

TitleReferenceAuthorSource BranchDest Branch
Release 0.3+deb12u1repos/sre/tcp-mss-clamper!7vgutierrez0.3-bookwormbookworm-wikimedia
Release 0.3+deb11u1repos/sre/ipip-multiqueue-optimizer!6vgutierrez0.3-bullseyebullseye-wikimedia
Customize query in GitLab

Event Timeline

Vgutierrez triaged this task as Medium priority.Nov 29 2023, 9:18 AM
Vgutierrez moved this task from Backlog to Traffic team actively servicing on the Traffic board.

Mentioned in SAL (#wikimedia-operations) [2023-11-29T10:57:16Z] <vgutierrez> upload ipip-multiqueue-optimizer 0.3+deb11u1 to apt.wm.o (bullseye) - T352249

Nov 29 11:04:34 lvs4008 ipip-multiqueue-optimizer[1925397]: 2023/11/29 11:04:34 Attaching IPIP Multiqueue Optimizer on vlan1201
Nov 29 11:04:34 lvs4008 ipip-multiqueue-optimizer[1925397]: 2023/11/29 11:04:34 Attaching IPIP Multiqueue Optimizer on enp175s0f0np0
Nov 29 11:04:43 lvs4008 ipip-multiqueue-optimizer[1925397]: 2023/11/29 11:04:43 Exiting
Nov 29 11:04:43 lvs4008 ipip-multiqueue-optimizer[1925397]: 2023/11/29 11:04:43 Detaching IPIP Multiqueue Optimizer from enp175s0f0np0
Nov 29 11:04:43 lvs4008 systemd[1]: Stopping eBPF based IPIP Multiqueue Optimizer...
Nov 29 11:04:43 lvs4008 ipip-multiqueue-optimizer[1925397]: 2023/11/29 11:04:43 Detaching IPIP Multiqueue Optimizer from vlan1201

working as expected now:

vgutierrez@lvs4008:~$ sudo -i bpftool prog |grep ipip
23278: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl
23279: sched_cls  name ipip_optimizer  tag 575f8397462edb4d  gpl
vgutierrez@lvs4008:~$ sudo -i systemctl stop ipip-multiqueue-optimizer.service 
vgutierrez@lvs4008:~$ sudo -i bpftool prog |grep ipip
[no output]

Mentioned in SAL (#wikimedia-operations) [2023-11-29T11:21:24Z] <vgutierrez> upload tcp-mss-clamper 0.3+deb12u1 to apt.wm.o (bookworm) - T352249