For donor prefs pages, offer to send a new link when checksum is expired
Open, Needs TriagePublic
Actions

Description

When a donor follows a link with an expired checksum, offer to send them a new link via email.

Will need to update the API calls to specify expired checksum errors and not just empty responses.

Details

Subject	Repo	Branch	Lines +/-
Message template for new checksum link	wikimedia/fundraising/crm	master	+119 -0
Queue consumer for new checksum link	wikimedia/fundraising/crm	master	+76 -1
Client side for requesting new checksum links	mediawiki/extensions/DonationInterface	master	+171 -27
API to request new link to RecurUpgrade or EmailPreferences	mediawiki/extensions/DonationInterface	master	+59 -0
Special return for valid but expired prefs link	wikimedia/fundraising/crm	master	+56 -3

Customize query in gerrit

Event Timeline

Ejegg created this task.Nov 29 2023, 9:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2023, 9:15 PM

AKanji-WMF moved this task from Triage to Later on the Fundraising-Backlog board.Nov 30 2023, 5:44 PM

AKanji-WMF added a project: fundraising near future temp.Feb 6 2024, 7:20 PM

AKanji-WMF removed a project: fundraising near future temp.Feb 6 2024, 8:13 PM

@Ejegg is this relevant to the current recurring upgrade work? - let me know if we should bring this in to Sprint E

@AKanji-WMF it would be nice, but maybe next sprint. The checksums shouldn't expire for 30 days, so this feature can wait a little bit

AKanji-WMF moved this task from Later to Sprint +1 on the Fundraising-Backlog board.Mar 19 2024, 8:32 PM

AKanji-WMF moved this task from Sprint +1 to Next on the Fundraising-Backlog board.May 21 2024, 8:18 PM

next recurring upgrade campaign is February 2025

Change #1073470 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Special return for valid but expired prefs link

https://gerrit.wikimedia.org/r/1073470

gerritbot added a project: Patch-For-Review.Sep 17 2024, 3:04 PM

This is newly urgent because we're moving to the Email Prefs page for unsubscribe links. Note we will also have to detect when the contact ID on the prefs link has been merged into another contact.

AKanji-WMF moved this task from Next to Sprint +1 on the Fundraising-Backlog board.Sep 20 2024, 5:32 PM

AKanji-WMF moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Oct 8 2024, 7:18 PM

AKanji-WMF added a project: Fundraising Sprint: trickOrTreat().Oct 8 2024, 7:59 PM

AKanji-WMF edited projects, added Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed(); removed Fundraising Sprint: trickOrTreat().Oct 22 2024, 7:54 PM

Ejegg claimed this task.Oct 25 2024, 8:17 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed() board.

Current thought: single API action on the Mediawiki side to ask for a new checksum link, with a link type enum (LINK_RECUR_UPGRADE/LINK_DONOR_PREFERENCES), optional subpage, and the contact ID.

I toyed with the idea of just accepting the old link and simply replacing the checksum parameter, but that would require parsing and validation to make sure we're only sending out links to the proper domain and only with reasonable querystring parameters. We can probably assume the number of people who are requesting a new link is small enough that we don't need to preserve tracking params like wmf_campaign.

Change #1015406 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] API to request new link to RecurUpgrade or EmailPreferences

https://gerrit.wikimedia.org/r/1015406

Change #1087562 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] WIP new checksum link JS and template

https://gerrit.wikimedia.org/r/1087562

AKanji-WMF edited projects, added Fundraising Sprint: void(); removed Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed().Wed, Nov 6, 2:21 AM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: void() board.Fri, Nov 8, 9:51 PM

AnnWF moved this task from Doing to Being Reviewed on the Fundraising Sprint: void() board.Sat, Nov 9, 12:20 AM

Change #1015406 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] API to request new link to RecurUpgrade or EmailPreferences

https://gerrit.wikimedia.org/r/1015406

Change #1087562 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Client side for requesting new checksum links

https://gerrit.wikimedia.org/r/1087562

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).Fri, Nov 15, 12:00 PM

AKanji-WMF edited projects, added Fundraising Sprint: wwwwwwwwwwwwwww(); removed Fundraising Sprint: void().Tue, Nov 19, 9:15 PM

AnnWF moved this task from Backlog to Ready for Review on the Fundraising Sprint: wwwwwwwwwwwwwww() board.Thu, Nov 21, 5:03 PM

Change #1094542 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Message template for new checksum link

https://gerrit.wikimedia.org/r/1094542

Change #1094543 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Queue consumer for new checksum link

https://gerrit.wikimedia.org/r/1094543

Change #1094542 merged by jenkins-bot: