Page MenuHomePhabricator
Create Task
Maniphest T352782

Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036
Closed, ResolvedPublic
Actions

Description

See rPHABde19094b2d611147713ade8131d64ad3b44d8036.

Where (URL) to see the impact of this change and these icons displayed?
In Wikimedia Phabricator, going to the "Manage" page of a project, selecting "Edit Picture", and selecting "Custom: Choose Icon and Color..." I still see items listed remove by this very patch.

What was the intention behind this commit, where to find related discussions?
I cannot find a Differential patchset, cannot find anything in Gerrit either.

Thanks for any hints in advance!

Details

TitleReferenceAuthorSource BranchDest Branch
Revert rPHABde19094b2d611147713ade8131d64ad3b44d8036repos/phabricator/phabricator!30aklapperT352782rmIconQuipswmf/stable
Customize query in GitLab

Related Objects

Event Timeline

Aklapper triaged this task as Low priority.Dec 5 2023, 3:34 PM
Aklapper created this task.
Aklapper renamed this task from Consider reverting custom "Updated built-in project profile icons" to Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036.Dec 19 2023, 9:17 AM
Aklapper claimed this task.

This custom code change did not "Removed a bunch of brand-specific icons" as its description says.
This code changed getIconQuips() and that very function only provides tooltips and does not change any selection of icons. Thus it made a bunch of icons not have a descriptive tooltip but display the internal filename as the tooltip instead:

T352782.png (802×1 px, 75 KB)

CodeReviewBot added a project: Patch-For-Review.Dec 19 2023, 9:35 AM

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/30

Revert rPHABde19094b2d611147713ade8131d64ad3b44d8036

CodeReviewBot added a comment.Dec 19 2023, 9:40 AM

aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/30

Revert rPHABde19094b2d611147713ade8131d64ad3b44d8036

Aklapper edited projects, added Phabricator (2024-01-09); removed Patch-For-Review, Phabricator.Dec 19 2023, 9:41 AM
Aklapper removed subscribers: Danny_B, 20after4.
Aklapper edited projects, added Phabricator (2024-01-16); removed Phabricator (2024-01-09).Jan 9 2024, 4:34 PM
Aklapper closed this task as Resolved.Jan 26 2024, 1:45 PM

Deployed on 2024-01-16

20after4 added a comment.Feb 1 2024, 6:58 AM
This comment was removed by 20after4.
20after4 added a comment.Feb 1 2024, 6:59 AM
In T352782#9414884, @Aklapper wrote:

This custom code change did not "Removed a bunch of brand-specific icons" as its description says.
This code changed getIconQuips() and that very function only provides tooltips and does not change any selection of icons. Thus it made a bunch of icons not have a descriptive tooltip but display the internal filename as the tooltip instead:

T352782.png (802×1 px, 75 KB)

Ah, totally possible that I made the change without adequately testing it. 2016 was so long ago I really can't remember.

20after4 added a comment.Feb 1 2024, 7:01 AM

What was the intention behind this commit, where to find related discussions?

I'm not sure anymore and I suspect it was a half-baked change that should have never made it in, it may have been accidentally pushed from a local change I was working on and didn't intend to publish in it's half-baked state.

Aklapper added a comment.Mar 17 2024, 5:17 PM

Heh, thanks! No worries :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL