Page MenuHomePhabricator
Create Task
Maniphest T353432

Warnings logged from DiscussionTools: Wikimedia\Rdbms\Platform\SQLPlatform::assertValidUpsertSetArray called with redundant assignment to column 'itr_revision_id' / 'itr_itemid_id'
Closed, ResolvedPublic
Actions

Description

I noticed this while reviewing the logs coming from RunSingleJob.php for T353262:

Wikimedia\Rdbms\Platform\SQLPlatform::assertValidUpsertSetArray called with redundant assignment to column 'itr_revision_id'
Wikimedia\Rdbms\Platform\SQLPlatform::assertValidUpsertSetArray called with redundant assignment to column 'itr_itemid_id'

https://logstash.wikimedia.org/goto/5933578675ea88387ff57ef726436434

image.png (532×2 px, 117 KB)

Details

SubjectRepoBranchLines +/-
ThreadItemStore: Omit redundant updates to avoid warningsmediawiki/extensions/DiscussionToolsmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Dec 14 2023, 10:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2023, 10:45 AM
matmarex claimed this task.Dec 14 2023, 10:46 AM
gerritbot added a comment.Dec 14 2023, 10:50 AM

Change 983155 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Omit redundant updates to avoid warnings

https://gerrit.wikimedia.org/r/983155

gerritbot added a project: Patch-For-Review.Dec 14 2023, 10:50 AM
gerritbot added a comment.Dec 14 2023, 11:06 AM

Change 983155 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ThreadItemStore: Omit redundant updates to avoid warnings

https://gerrit.wikimedia.org/r/983155

matmarex closed this task as Resolved.Dec 14 2023, 11:08 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 11:10 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 14 2023, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL