Page MenuHomePhabricator
Create Task
Maniphest T353522

Rework CommonsMetadata LocalFileMock and ForeignDBFileMock hack to support php8.2 in the extension
Closed, ResolvedPublic
Actions

Description

The DataCollector in CommonsMetadata is looking for instance of LocalFileMock or ForeignDBFileMock to return the property $mockedCategories, the property is declared on the mock object and that means it is dynamic created, that is deprecated in php8.2

1) CommonsMetadata\HookHandlerTest::testLocalFile
Creation of dynamic property LocalFileMock::$mockedCategories is deprecated

/workspace/src/extensions/CommonsMetadata/tests/phpunit/ParserTestHelper.php:144
/workspace/src/extensions/CommonsMetadata/tests/phpunit/HookHandlerTest.php:33

Details

SubjectRepoBranchLines +/-
tests: Declare ParserTestHelper::$mockedCategoriesmediawiki/extensions/CommonsMetadataREL1_42+10 -7
tests: Declare ParserTestHelper::$mockedCategoriesmediawiki/extensions/CommonsMetadatamaster+10 -7
Customize query in gerrit

Event Timeline

Umherirrender created this task.Dec 15 2023, 2:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2023, 2:21 PM
Umherirrender moved this task from Backlog to Wikimedia production on the PHP 8.2 support board.Dec 18 2023, 7:05 PM
Umherirrender unsubscribed.Feb 11 2024, 12:07 AM
gerritbot added a comment.Sun, Jun 9, 8:24 AM

Change #983417 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommonsMetadata@master] tests: Declare ParserTestHelper::$mockedCategories

https://gerrit.wikimedia.org/r/983417

gerritbot added a project: Patch-For-Review.Sun, Jun 9, 8:24 AM
gerritbot added a comment.Sun, Jun 9, 10:38 PM

Change #983417 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@master] tests: Declare ParserTestHelper::$mockedCategories

https://gerrit.wikimedia.org/r/983417

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Sun, Jun 9, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sun, Jun 9, 11:30 PM
gerritbot added a comment.Sat, Jun 15, 6:10 AM

Change #1044275 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommonsMetadata@REL1_42] tests: Declare ParserTestHelper::$mockedCategories

https://gerrit.wikimedia.org/r/1044275

gerritbot added a project: Patch-For-Review.Sat, Jun 15, 6:10 AM
gerritbot added a comment.Sat, Jun 15, 6:35 AM

Change #1044275 merged by jenkins-bot:

[mediawiki/extensions/CommonsMetadata@REL1_42] tests: Declare ParserTestHelper::$mockedCategories

https://gerrit.wikimedia.org/r/1044275

Maintenance_bot removed a project: Patch-For-Review.Sat, Jun 15, 7:30 AM
Umherirrender closed this task as Resolved.Sun, Jun 16, 11:24 AM
Umherirrender claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits