Page MenuHomePhabricator
Create Task
Maniphest T354090

Malformed JSONpath can cause a PHP warning
Closed, ResolvedPublicBUG REPORT
Actions

Description

Malformed JSONpath like .records[] can cause a PHP warning abount an undefined string index from includes/EDJsonObject.php, line 458, because $contents is empty.

Details

SubjectRepoBranchLines +/-
Improve handling of bad JSONpathmediawiki/extensions/ExternalDatamaster+14 -4
Customize query in gerrit

Event Timeline

alex-mashin created this task.Dec 29 2023, 5:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2023, 5:12 AM
alex-mashin changed the task status from Open to In Progress.Dec 29 2023, 5:12 AM
alex-mashin claimed this task.
gerritbot added a comment.Dec 29 2023, 5:54 AM

Change 986534 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Improve handling of bad JSONpath

https://gerrit.wikimedia.org/r/986534

gerritbot added a project: Patch-For-Review.Dec 29 2023, 5:54 AM
gerritbot added a comment.Dec 29 2023, 6:33 AM

Change 986534 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Improve handling of bad JSONpath

https://gerrit.wikimedia.org/r/986534

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2023, 7:30 AM
alex-mashin closed this task as Resolved.Dec 29 2023, 8:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL