Maniphest T35451

mw-collapsible element with multiple mw-customcollapible IDs does not work
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Badon
	Dec 31 2011, 11:50 PM

Tags

Referenced Files

None

Subscribers

• TrevorParscal

• wikibugs-l-list

Description

All 3 of these should produce the same results, but they don't:

<span class="mw-customtoggle-I">Nest I</span>
<ol class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">
<li>

		<span class="mw-customtoggle-IIA">Nest IIA</span>
		<ol class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIA" style="list-style-type:upper-alpha">
			<li>
				content
			</li>
		</ol>

</li>
<li>

		<span class="mw-customtoggle-IIB">Nest IIB</span>
		<ol class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIB" style="list-style-type:upper-alpha">
			<li>
				content
			</li>
		</ol>

</li>
<li>

		<span class="mw-customtoggle-IIC">Nest IIC</span>
		<ol class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIC" style="list-style-type:upper-alpha">
			<li>
				content
			</li>
		</ol>

</li>
</ol>

<table class="wikitable">
<tr>

		<th class="mw-customtoggle-I" style="background-color:#ccccff;">Nest I</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIA">Nest IIA</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIA">

		<td>
			content
		</td>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIB">Nest IIB</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIB">

		<td>
			content
		</td>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIC">Nest IIC</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-IIC">

		<td>
			content
		</td>

</tr>
</table>

<table class="wikitable">
<tr>

		<th class="mw-customtoggle-I" style="background-color:#ccccff;">Nest I</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIA">Nest IIA</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I mw-customcollapsible-IIA">

		<td>
			content
		</td>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIB">Nest IIB</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I mw-customcollapsible-IIB">

		<td>
			content
		</td>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I">

		<th class="mw-customtoggle-IIC">Nest IIC</th>

</tr>
<tr class="mw-collapsible mw-collapsed" id="mw-customcollapsible-I mw-customcollapsible-IIC">

		<td>
			content
		</td>

</tr>
</table>

The problem is in the last table. Tables can't be nested the way lists can, so nested toggle behavior can only be done by adding the toggle id's from all of the toggles you want to be able to toggle the element. Each toggle id needs to function in an OR relationship, where ANY 1 of the toggles will toggle the element. I haven't looked at the code myself, but I think it's trying to function only in an AND relationship, where all of the toggles need to be triggered to toggle the element.

That's the only way I can think of to nest toggle functionality with elements that are not syntactically nestable. The result is that only the first table is usable, and it only collapses the elements when they are toggled in the reverse order they were expanded (LIFO order).

Version: 1.18.x
Severity: normal

Details

Reference: bz33451

	Title	Reference	Author	Source Branch	Dest Branch
	Override envoy request timeout	repos/search-platform/cirrus-streaming-updater!97	pfischer	envoy-timeout	main
	Update function-schemata sub-module to HEAD (1a02a7d)	repos/abstract-wiki/wikifunctions/function-orchestrator!120	jforrester	sync-function-schemata	main
	Update function-schemata sub-module to HEAD (1a02a7d)	repos/abstract-wiki/wikifunctions/function-evaluator!141	jforrester	sync-function-schemata	main
	Update function-schemata sub-module to HEAD (1a02a7d)	repos/abstract-wiki/wikifunctions/wikilambda-cli!25	jforrester	sync-function-schemata	main
	definitions: Add Z1917/ttj ZNaturalLanguage	repos/abstract-wiki/wikifunctions/function-schemata!71	jforrester	language-ttj	main

Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:04 AM

• bzimport added a project: MediaWiki-JavaScript.

• bzimport set Reference to bz33451.

• bzimport added a subscriber: Unknown Object (MLST).

Badon created this task.Dec 31 2011, 11:50 PM

There is a demo of this bug here (login with Demo/test):

http://www.coincompendium.com/w/index.php/Sandbox/Bug_33451

I'll check this out further at a later time, but right now I notice that the same ID is used multiple times, that's impossible in the browser DOM model, simply doesn't exist.

Also, an element can have only one ID, not several separated by space. This is the way the HTML specification works, not MediaWiki specific.

One more thing, using that example (and the login you gave me earlier) in Google Chrome works fine for me.

All three "List 1" will toggle the list and the two tables.
All three "Nest IIA", "Nest IIB" and "Nest IIC" trigger the content in the first table and in the list.

It will not trigger the content in the third table, and that's perfectly fine. Considering the content cell there has an ID of "mw-customcollapsible-I_mw-customcollapsible-IIB" which has no trigger anywhere.

Resolved further on IRC. Marking invalid.

OK, I got the cause wrong so it's not a bug, but perhaps I can come up with something as an enhancement. My original title for this report was: "MakeCollapsible nesting of toggle id's does not work".

It seems there's no way to get nested behavior in non-nested elements - at least not with id's. Doing it with classes does not toggle at all. For non-nested elements, like in a table, it'll probably have to do some sort of smart toggling where if it collapses a parent element, it also collapses child elements, without blindly toggling them to a different state (possibly expanding them instead of collapsing).

I'm not sure how that should be approached, but I think it'll have to be done in the JS, with some new usage methods. Most importantly, I think it'll have to work with classes in addition to id's. Dynamically generated tables would need to also have dynamically generated id's, which is unnecessary if it works with classes. Is that doable, or is there a technical reason why it only works with id's?

I was hoping there was a better solution than nesting entire groups of code in non-naturally nested elements, but it does work that way. For some nested table nightmares, have a flashback to 1990:

http://www.coincompendium.com/w/index.php/Sandbox/Nested_MakeCollapsible