Page MenuHomePhabricator

clearTagHooks doesn't clear function hooks
Closed, ResolvedPublic

Description

Author: Nx.devnull

Description:
patch

Parser:clearTagHooks clears mTagHooks and resets mStripList to the default. However, it does not clear mFunctionTagHooks.

setFunctionTagHook adds a function tag to the strip list, so this creates an inconsistent state, where the tag is present in mFunctionTagHooks, but not mStripList.

As far as I can tell, clearTagHooks isn't called anywhere in core, and I don't know what its purpose is, but just clearing function tag hooks as well in clearTagHooks seems like a sensible fix.


Version: 1.20.x
Severity: normal

Attached:

Details

Reference
bz33525

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:09 AM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz33525.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Jan 4 2012, 9:21 PM
Reedy added a comment.Jan 4 2012, 9:30 PM

Applied in r108087, thanks!