Page MenuHomePhabricator

requestctl should fail with error if fails parsing yaml file
Open, In Progress, MediumPublic

Description

if requestctl is unable to parse a yaml file during sync emits errors at DEBUG level:

  • sudo requestctl --debug -g /srv/private/requestctl sync ipblock
[...snip...]
2024-01-17 18:19:10,078 - conftool (__init__:yaml_log_error:89) - DEBUG - Error parsing yaml file <REDACTED>.yaml: while scanning a plain scalar
  in "<REDACTED>.yaml", line 1008, column 3
found unexpected ':'
  in "<REDACTED>.yaml", line 1008, column 7
Please check http://pyyaml.org/wiki/YAMLColonInFlowContext for details.
[...snip...]

Without using the --debug flag this gives no output at all so it's hard to tell if the sync has failed or not. Failed parsing should be raised at ERROR level.

Event Timeline

Change 992104 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/software/conftool@master] Raise yaml_log_error logging level to error

https://gerrit.wikimedia.org/r/992104

Clement_Goubert changed the task status from Open to In Progress.Jan 22 2024, 11:32 AM
Clement_Goubert claimed this task.
Clement_Goubert triaged this task as Medium priority.
Clement_Goubert moved this task from Backlog to in progress on the conftool board.
Clement_Goubert moved this task from Incoming 🐫 to Doing 😎 on the serviceops board.

Change 992104 merged by jenkins-bot:

[operations/software/conftool@master] Raise yaml_log_error logging level to error

https://gerrit.wikimedia.org/r/992104