Page MenuHomePhabricator

Avoid error logging while searching configs during normal operation
Closed, ResolvedPublic

Description

Forking from T365123#9904990:

In https://gerrit.wikimedia.org/r/992104, the default log level for YAML loading errors was increased from debug to error to address T355256.

However, given the way conftool enumerates possibly-non-existent config files during initialization, and this is now rather noisy. We should either (1) not attempt to config load files that do not exist or (2) limit the scope of ERROR logging to only the invalid-YAML case (original intent).

Event Timeline

Change #1047193 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/software/conftool@master] drivers/etcd: only attempt to load existing configs

https://gerrit.wikimedia.org/r/1047193

Marostegui subscribed.

Let's make this high as the error is confusing enough to make one think this is broken :)

Change #1047193 merged by jenkins-bot:

[operations/software/conftool@master] drivers/etcd: only attempt to load existing configs

https://gerrit.wikimedia.org/r/1047193

Change #1047245 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/software/conftool@master] Release 3.0.1

https://gerrit.wikimedia.org/r/1047245

Change #1047245 merged by jenkins-bot:

[operations/software/conftool@master] Release 3.0.1

https://gerrit.wikimedia.org/r/1047245

Joe raised the priority of this task from High to Unbreak Now!.Jun 19 2024, 6:08 AM
Joe subscribed.

Raising to unbreak now as this breaks some scripts that rely on parsing the output of conftool

Mentioned in SAL (#wikimedia-operations) [2024-06-19T06:08:18Z] <_joe_> uploaded newer python-conftool packages T367919

Mentioned in SAL (#wikimedia-operations) [2024-06-19T06:21:10Z] <_joe_> upgrading conftool everywhere T367919

This should be fixed everywhere.