Page MenuHomePhabricator
Create Task
Maniphest T357339

PHP Fatal error: Cannot declare class HookRunnerTest, because the name is already in use
Closed, ResolvedPublic
Actions

Description

It seems unnamespaced HookRunnerTest is used in CentralNotice, FlaggedRevs, and AdminLinks (from a quick search), so if any of these extensions are used together in tests it causes them to fail. This seems to be the issue with Cosmos, which tests load AdminLinks and FlaggedRevs causing tests to continuously fail due to it.

Details

SubjectRepoBranchLines +/-
Merge branch 'master' into wmf_deploymediawiki/extensions/CentralNoticewmf_deploy+0 -0
Rename HookRunnerTestmediawiki/extensions/CentralNoticemaster+1 -1
Rename HookRunnerTestmediawiki/extensions/FlaggedRevsmaster+1 -1
Rename HookRunnerTestmediawiki/extensions/AdminLinksmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Universal_Omega created this task.Feb 12 2024, 6:07 PM
gerritbot added a comment.Feb 12 2024, 7:28 PM

Change 1002600 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002600

gerritbot added a project: Patch-For-Review.Feb 12 2024, 7:28 PM
gerritbot added a comment.Feb 12 2024, 7:31 PM

Change 1002601 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002601

gerritbot added a comment.Feb 12 2024, 7:31 PM

Change 1002602 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AdminLinks@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002602

gerritbot added a comment.Feb 12 2024, 9:08 PM

Change 1002601 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002601

gerritbot added a comment.Feb 12 2024, 9:08 PM

Change 1002602 merged by jenkins-bot:

[mediawiki/extensions/AdminLinks@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002602

gerritbot added a comment.Feb 12 2024, 9:08 PM

Change 1002600 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Rename HookRunnerTest

https://gerrit.wikimedia.org/r/1002600

Umherirrender closed this task as Resolved.Feb 12 2024, 9:08 PM
Umherirrender claimed this task.
Umherirrender removed a project: Patch-For-Review.
Umherirrender mentioned this in rEADLb42aff7b3883: Rename HookRunnerTest.Feb 12 2024, 9:15 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 12 2024, 10:00 PM
gerritbot added a comment.Jul 8 2024, 8:31 AM

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

gerritbot added a project: Patch-For-Review.Jul 8 2024, 8:31 AM
gerritbot added a comment.Jul 22 2024, 8:57 PM

Change #1052668 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2024, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits