Page MenuHomePhabricator

Disable DarkMode extension on Minerva and Vector 2022
Closed, ResolvedPublic

Description

Given these skins have their own native night mode under implementation, we should stop the extension applying to those. The two are in conflict.

We can re-assess closer to the release to make sure we don't disrupt the night mode experience.

This decision came out of this discussion:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DarkMode/+/994817/comments/ef602a85_d7f9d908

Event Timeline

Change 1003577 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Disable Extension:DarkMode on Minerva

https://gerrit.wikimedia.org/r/1003577

Change 1003532 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Disable Extension:DarkMode on Vector 2022

https://gerrit.wikimedia.org/r/1003532

Change 1003577 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Disable Extension:DarkMode on Minerva

https://gerrit.wikimedia.org/r/1003577

Change 1003818 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Restore light mode palette for Extension:DarkMode

https://gerrit.wikimedia.org/r/1003818

Change 1003532 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Disable Extension:DarkMode on Vector 2022

https://gerrit.wikimedia.org/r/1003532

Jdlrobson claimed this task.

Change #1003818 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Restore light mode palette for Extension:DarkMode

Reason:

https://gerrit.wikimedia.org/r/1003818

Note: We reverted https://gerrit.wikimedia.org/r/1003532 for 1.42 branch. We'll now aim to have native dark mode in Vector 2022 for 1.43.