Page MenuHomePhabricator

Opening the OCR menu does not focus the popup
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Nothing in the popup is focused. Pressing the arrows keys moves the page up and down. Pressing tab focuses the "Advanced" toolbar instead. Pressing enter closes the popup.

What should have happened instead?:

It should focus the radio buttons, as the first thing in the popup, so that keyboard navigation works properly.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JWheeler-WMF moved this task from New & TBD Tickets to CommTech Backlog on the Community-Tech board.
JWheeler-WMF subscribed.

This is a valid bug however I'm not sure about priority due to adoption and usage of OCR

At first glance, it looks like a case of enabling focus for the panel (the removing focus part was done in T316119). I can take a look at fixing this.

Change #1024985 had a related patch set uploaded (by Theprotonade; author: Theprotonade):

[mediawiki/extensions/Wikisource@master] Focus radio button on opening OCR popup

https://gerrit.wikimedia.org/r/1024985

Change #1024985 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Focus radio button on opening OCR popup

https://gerrit.wikimedia.org/r/1024985

theprotonade claimed this task.