Page MenuHomePhabricator

Changing OCR tool can stop arrow keys and enter working in wikieditor on Firefox
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

If I change the OCR transcription tool (e.g. from Tesseract to Google), I can no longer use the arrow keys or enter when editing the wikitext.

It seems to happen if I click anywhere in the tool selection dropdown apart from directly on the radio buttons or the "Advanced Options" link.

Even after I have closed the OCR selection tool, pressing the up and down arrow keys changes the radio button that switches between tools, as if it still has focus.

I have only been able to reproduce this on Firefox (including the latest 104), not on Chrome or Safari.

Steps to reproduce problem
  1. Edit a transcription page (e.g. https://en.wikisource.org/w/index.php?title=Page:Prevention_of_Bribery_Ordinance_1970_(Cap._201).pdf/20&action=edit )
  2. Click the down arrow next to "Transcribe text"
  3. In the dropdown, click on the words "Google OCR"
  4. Put your cursor in the wikitext editing box
  5. Press enter or use the arrow keys

Expected behavior: Enter and arrow keys make the appropriate changes to the wikitext.
Observed behavior: Nothing appears to happen. However, if you open the tool selection dropdown again you might notice the selected tool has changed.

Environment

Environment: https://en.wikisource.org Wikisource – (ee7fe53) 06:44, 12 August 2022.
Browser: Firefox 91, 104.

Screenshots

ocr_tool_selection.png (569×1 px, 301 KB)

Event Timeline

Change 908968 had a related patch set uploaded (by Parthiv; author: Parthiv):

[mediawiki/extensions/Wikisource@master] Remove focus from OCR selection popup after engine selection

https://gerrit.wikimedia.org/r/908968

Change 908968 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Remove focus from OCR selection popup after engine selection

https://gerrit.wikimedia.org/r/908968