Page MenuHomePhabricator

hieradata for syslog/centralserver should use hash instead of array for env_variables
Closed, ResolvedPublic

Description

Writing hieradata/hosts/cp4037.yaml we noticed that using an array for env_variables produces an error in PCC:

Error: Evaluation Error: Error while evaluating a '+' expression, odd number of arguments for Hash (file: /srv/jenkins/puppet-compiler/1489/change/src/modules/profile/manifests/benthos.pp, line: 31, column: 50)

As noticed by @Joe the issue resides in the env_variables hiera structure that should be an hash, instead of a list. Exceptionally, when the list contains just one element, the result is the expected one.

Event Timeline

Change 1007299 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] hiera: minor fix for benthos env_variables structure

https://gerrit.wikimedia.org/r/1007299

Change #1007299 merged by Fabfur:

[operations/puppet@production] hiera: minor fix for benthos env_variables structure

https://gerrit.wikimedia.org/r/1007299

fgiunchedi claimed this task.
fgiunchedi subscribed.

Done by @Fabfur, thank you!