Ability to disable footer links with "-" stopped working in 1.40
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nikerabbit
	Mar 5 2024, 6:44 AM

Description

Steps to replicate the issue (include links if applicable):

Edit MediaWiki:disclaimers (for example) to contain "-"

What happens?:
See a dash on footer

What should have happened instead?:
The footer link should be disabled

Software version (skip for WMF-hosted wikis like Wikipedia):
1.40.2

Other information (browser name/version, screenshots, etc.):

Trying to disable with space doesn't work either:

<ul id="footer-places">
<li id="footer-places-privacy"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6">Käyttöehdot</a></li>
<li id="footer-places-about"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6"></a></li>
<li id="footer-places-disclaimers"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6"></a></li>

Details

Subject	Repo	Branch	Lines +/-
Make footer links disableable	mediawiki/core	REL1_40	+8 -7
Make footer links disableable	mediawiki/core	REL1_41	+8 -7
Make footer links disableable	mediawiki/core	master	+7 -7

Customize query in gerrit

Related Objects

Mentioned Here: rMW9c4f70c22251: Componentize menulink + footer

Event Timeline

Nikerabbit created this task.Mar 5 2024, 6:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2024, 6:44 AM

Dringsim added a project: Regression.Mar 5 2024, 2:30 PM

Trying to disable with space doesn't work either:

<ul id="footer-places">
<li id="footer-places-privacy"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6">Käyttöehdot</a></li>
<li id="footer-places-about"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6"></a></li>
<li id="footer-places-disclaimers"><a href="/wiki/Nimiarkisto:Tietosuojak%C3%A4yt%C3%A4nt%C3%B6"></a></li>

Also the two "disabled" footer links are pointed to the privacy policy (Mediawiki:privacypage), same as the first and non-disabled footer link.

Change 1008875 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/core@master] Make footer links disableable

https://gerrit.wikimedia.org/r/1008875

gerritbot added a project: Patch-For-Review.Mar 5 2024, 2:55 PM

This was introduced in rMW9c4f70c22251: Componentize menulink + footer.

Test wiki created on Patch demo by 沈澄心 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/66e30542b9/w