Page MenuHomePhabricator
Create Task
Maniphest T359230

Filter debug log messages out of logs sent to disk
Closed, ResolvedPublicFeature
Actions

Description

It is nice to have really verbose logging available, but sending lots and lots of noise to disk every second isn't ideal.

[pod/phorge-78c48c4cbc-56xmc/job] 2024-03-06T00:39:29Z urllib3.connectionpool DEBUG: https://phabricator.wikimedia.org:443 "POST /api/feed.query HTTP/1.1" 200 58
[pod/phorge-78c48c4cbc-56xmc/job] 2024-03-06T00:39:29Z wikibugs2.phorge DEBUG: feed.query result: {'result': [], 'error_code': None, 'error_info': None}

This should also involve auditing log levels to see what should be raised to INFO or higher so that it does still persist to disk.

Details

TitleReferenceAuthorSource BranchDest Branch
Filter debug log messages out of logs sent to disktoolforge-repos/wikibugs2!13bd808work/bd808/T359230-debug-logsmain
Customize query in GitLab

Related Objects

Event Timeline

bd808 created this task.Mar 6 2024, 12:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 12:40 AM
bd808 added a comment.Mar 6 2024, 7:10 PM

One way to expose control of this that might be cute would be to make the -v, --verbose flag's additive effect follow this progression:

  • no flag: log to disk and console at WARNING level (current behavior)
  • -v: log to disk and console at INFO level (current behavior)
  • -vv: log to disk at INFO level and console at DEBUG level (new behavior; current would log to both at DEBUG level)
  • -vvv: log to disk and console at DEBUG level (current behavior)

The change here at the code level would be deciding what level to set on the wikibugs2.wblogging.PrivateTimedRotatingFileHandler object used to manage disk logging. Currently we do an unconditional handler.setLevel(logging.DEBUG) so that anything that makes it past the root logger's level filter is recorded.

bd808 moved this task from Backlog to Ready to Go on the Wikibugs board.Mar 6 2024, 7:12 PM
bd808 changed the task status from Open to In Progress.Mar 7 2024, 3:47 AM
bd808 claimed this task.
bd808 moved this task from Ready to Go to Doing on the Wikibugs board.
Restricted Application added a project: User-bd808. · View Herald TranscriptMar 7 2024, 3:47 AM
CodeReviewBot added a project: Patch-For-Review.Mar 7 2024, 4:02 AM

bd808 opened https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/13

Filter debug log messages out of logs sent to disk

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2024, 4:30 AM
CodeReviewBot added a comment.Mar 7 2024, 9:04 PM

bd808 merged https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/13

Filter debug log messages out of logs sent to disk

Stashbot mentioned this in T359202: Add support for alternate channels files to make testing/debugging easier.Mar 7 2024, 9:22 PM
Stashbot mentioned this in T359228: Allow configuration of update announce channel.

Mentioned in SAL (#wikimedia-cloud) [2024-03-07T21:22:04Z] <wmbot~bd808@tools-sgebastion-11> Updated to c42300f (T359230, T359202, T359228)

bd808 closed this task as Resolved.Mar 7 2024, 9:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL