Page MenuHomePhabricator

Cleanup parsoid-php service
Closed, ResolvedPublic

Description

Per T357392 and T358752, we 've migrated all of traffic away from the parsoid-php service. This is a followup task to clean up after the migration as the main migration task is probably best resolved.

Things to definitely clean up:

  • Removal of parsoid-php from the services_proxy
  • Removal of parsoid-async (it is apparently unused) from the service::catalog
  • Removal of parsoid-php from the service::catalog
  • Reimaging of parse1001, parse2001 as WikiKube nodes
  • Any RESTBase configuration leftovers in puppet

This to possibly clean up:

[ ] Parsoid Puppet Code In the interest of not breaking deployment-prep/beta, we 'll keep the code around for some (currently undecided and undefined) time

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptMar 6 2024, 2:32 PM

Change 1006899 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] Clean up all the RESTBase hosts's parsoid uri changes

https://gerrit.wikimedia.org/r/1006899

Change 1006900 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] services_proxy: Remove parsoid-php, parsoid-async

https://gerrit.wikimedia.org/r/1006900

Change #1018660 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/deployment-charts@master] Remove parsoid-php certificates from mw deployments

https://gerrit.wikimedia.org/r/1018660

Change #1018661 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/deployment-charts@master] fixtures: Rename all parsoid-php references

https://gerrit.wikimedia.org/r/1018661

Change #1020807 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Remove parsoid-canary Cumin alias

https://gerrit.wikimedia.org/r/1020807

Change #1020807 merged by Muehlenhoff:

[operations/puppet@production] Remove parsoid-canary Cumin alias

https://gerrit.wikimedia.org/r/1020807

Change #1006899 merged by Alexandros Kosiaris:

[operations/puppet@production] Clean up all the RESTBase hosts's parsoid uri changes

https://gerrit.wikimedia.org/r/1006899

Change #1058165 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/deployment-charts@master] Switch all fixtures to mw-parsoid from parsoid-php

https://gerrit.wikimedia.org/r/1058165

Change #1058165 abandoned by Alexandros Kosiaris:

[operations/deployment-charts@master] Switch all fixtures to mw-parsoid from parsoid-php

Reason:

Already done in https://gerrit.wikimedia.org/r/c/operations/puppet/+/1006900

https://gerrit.wikimedia.org/r/1058165

Change #1058166 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/deployment-charts@master] Remove parsoid-async from fixtures

https://gerrit.wikimedia.org/r/1058166

Change #1018661 merged by jenkins-bot:

[operations/deployment-charts@master] fixtures: Rename all parsoid-php references

https://gerrit.wikimedia.org/r/1018661

Change #1018660 merged by jenkins-bot:

[operations/deployment-charts@master] Remove parsoid-php certificates from mw deployments

https://gerrit.wikimedia.org/r/1018660

Change #1058166 merged by jenkins-bot:

[operations/deployment-charts@master] Remove parsoid-async from fixtures

https://gerrit.wikimedia.org/r/1058166

Change #1006900 merged by Alexandros Kosiaris:

[operations/puppet@production] services_proxy: Remove parsoid-php, parsoid-async

https://gerrit.wikimedia.org/r/1006900

Change #1058169 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] parsoid-php: remove discovery, hosts, dsh groups

https://gerrit.wikimedia.org/r/1058169

Change #1058171 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] service: Switch parsoid-php to service_setup

https://gerrit.wikimedia.org/r/1058171

Change #1058171 merged by Alexandros Kosiaris:

[operations/puppet@production] service: Switch parsoid-php to service_setup

https://gerrit.wikimedia.org/r/1058171

Change #1058189 had a related patch set uploaded (by Ssingh; author: Ssingh):

[operations/dns@master] Remove parsoid-php discovery record

https://gerrit.wikimedia.org/r/1058189

Change #1058189 merged by Alexandros Kosiaris:

[operations/dns@master] Remove parsoid-php discovery record

https://gerrit.wikimedia.org/r/1058189

Mentioned in SAL (#wikimedia-operations) [2024-07-30T15:20:50Z] <akosiaris> restart pybal for parsoid-php removal on lvs1020, lvs2014 T359387

Mentioned in SAL (#wikimedia-operations) [2024-07-30T15:56:39Z] <akosiaris> restart pybal for parsoid-php removal on lvs1019, lvs2013 T359387

Change #1058169 merged by Alexandros Kosiaris:

[operations/puppet@production] parsoid-php: remove discovery, conftool, dsh groups

https://gerrit.wikimedia.org/r/1058169

Change #1058562 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] service: Remove old parsoid-php from catalog

https://gerrit.wikimedia.org/r/1058562

Change #1058559 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):

[operations/puppet@production] parse[12]001: Move them to wikikube workers

https://gerrit.wikimedia.org/r/1058559

Change #1058562 merged by Alexandros Kosiaris:

[operations/puppet@production] service: Remove old parsoid-php from catalog

https://gerrit.wikimedia.org/r/1058562

Change #1058559 merged by Alexandros Kosiaris:

[operations/puppet@production] parse[12]001: Move them to wikikube workers

https://gerrit.wikimedia.org/r/1058559

Cookbook cookbooks.sre.hosts.reimage was started by akosiaris@cumin1002 for host parse1001.eqiad.wmnet with OS bullseye

Cookbook cookbooks.sre.hosts.reimage was started by akosiaris@cumin1002 for host parse2001.codfw.wmnet with OS bullseye

Cookbook cookbooks.sre.hosts.reimage started by akosiaris@cumin1002 for host parse1001.eqiad.wmnet with OS bullseye completed:

  • parse1001 (PASS)
    • Downtimed on Icinga/Alertmanager
    • Disabled Puppet
    • Removed from Puppet and PuppetDB if present and deleted any certificates
    • Removed from Debmonitor if present
    • Forced PXE for next reboot
    • Host rebooted via IPMI
    • Host up (Debian installer)
    • Add puppet_version metadata to Debian installer
    • Checked BIOS boot parameters are back to normal
    • Host up (new fresh bullseye OS)
    • Generated Puppet certificate
    • Signed new Puppet certificate
    • Run Puppet in NOOP mode to populate exported resources in PuppetDB
    • Found Nagios_host resource for this host in PuppetDB
    • Downtimed the new host on Icinga/Alertmanager
    • Removed previous downtime on Alertmanager (old OS)
    • First Puppet run completed and logged in /var/log/spicerack/sre/hosts/reimage/202407311042_akosiaris_3509417_parse1001.out
    • configmaster.wikimedia.org updated with the host new SSH public key for wmf-update-known-hosts-production
    • Rebooted
    • Automatic Puppet run was successful
    • Forced a re-check of all Icinga services for the host
    • Icinga status is optimal
    • Icinga downtime removed
    • Updated Netbox data from PuppetDB

Cookbook cookbooks.sre.hosts.reimage started by akosiaris@cumin1002 for host parse2001.codfw.wmnet with OS bullseye completed:

  • parse2001 (PASS)
    • Downtimed on Icinga/Alertmanager
    • Disabled Puppet
    • Removed from Puppet and PuppetDB if present and deleted any certificates
    • Removed from Debmonitor if present
    • Forced PXE for next reboot
    • Host rebooted via IPMI
    • Host up (Debian installer)
    • Add puppet_version metadata to Debian installer
    • Checked BIOS boot parameters are back to normal
    • Host up (new fresh bullseye OS)
    • Generated Puppet certificate
    • Signed new Puppet certificate
    • Run Puppet in NOOP mode to populate exported resources in PuppetDB
    • Found Nagios_host resource for this host in PuppetDB
    • Downtimed the new host on Icinga/Alertmanager
    • Removed previous downtime on Alertmanager (old OS)
    • First Puppet run completed and logged in /var/log/spicerack/sre/hosts/reimage/202407311046_akosiaris_3509571_parse2001.out
    • configmaster.wikimedia.org updated with the host new SSH public key for wmf-update-known-hosts-production
    • Rebooted
    • Automatic Puppet run was successful
    • Forced a re-check of all Icinga services for the host
    • Icinga status is optimal
    • Icinga downtime removed
    • Updated Netbox data from PuppetDB
akosiaris claimed this task.

Node reimaged, pooled with weight 10 and uncordoned. I 'll happily resolve this, the legacy parsoid cluster is no more!

Mentioned in SAL (#wikimedia-operations) [2024-08-01T07:03:59Z] <akosiaris> uncordon parse2001, parse1001 T359387

Change #1063261 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/cookbooks@master] Remove parsoid-php from MEDIAWIKI_SERVICES

https://gerrit.wikimedia.org/r/1063261

Change #1063744 had a related patch set uploaded (by Clรฉment Goubert; author: Clรฉment Goubert):

[operations/puppet@production] cumin: Remove parsoid from aliases

https://gerrit.wikimedia.org/r/1063744

Change #1063744 merged by Clรฉment Goubert:

[operations/puppet@production] cumin: Remove parsoid from aliases

https://gerrit.wikimedia.org/r/1063744

Change #1063261 merged by jenkins-bot:

[operations/cookbooks@master] Remove parsoid-php from MEDIAWIKI_SERVICES

https://gerrit.wikimedia.org/r/1063261

Change #1072737 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Remove old parsoid certs

https://gerrit.wikimedia.org/r/1072737

Change #1072738 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[labs/private@master] labs-private: Remove parsoid stub secrets

https://gerrit.wikimedia.org/r/1072738

Change #1072737 merged by Alexandros Kosiaris:

[operations/puppet@production] Remove old parsoid certs

https://gerrit.wikimedia.org/r/1072737

Change #1072738 merged by Alexandros Kosiaris:

[labs/private@master] labs-private: Remove parsoid stub secrets

https://gerrit.wikimedia.org/r/1072738