Page MenuHomePhabricator

[envvars-cli] Either hide or show envvars values, but not both
Closed, ResolvedPublic

Description

When creating new envvars from the stdin prompt, the value is hidden while typing, but is then promptly displayed once done, defeating the purpose of hiding it in the first place.

tools.django-test@tools-sgebastion-10:~$ toolforge envvars create DJANGO_SUPERUSER_USERNAME
Enter the value of your envvar (prompt is hidden, hit Ctrl+C to abort):
name                       value
DJANGO_SUPERUSER_USERNAME  admin2

Suggestion:
Hide the prompt as a default. Add a --show flag or similar to see the value as you type. In both cases, do not automatically show the value.

Details

TitleReferenceAuthorSource BranchDest Branch
d/changelog: bump to 0.0.5repos/cloud/toolforge/envvars-cli!30sstefanovabump_to_0.0.5main
create: show promptrepos/cloud/toolforge/envvars-cli!29ebomanienvvars-updatemain
Customize query in GitLab

Event Timeline

Agree, maybe we don't need to hide the prompt at all, the main issue was avoiding having it in the shell history, showing it when prompting should be ok imo

dcaro triaged this task as Low priority.Mar 7 2024, 5:24 PM
dcaro moved this task from Backlog to Ready to be worked on on the Toolforge board.