Page MenuHomePhabricator

MediaModeration CI failing with "Passing an argument of type Generator for the $haystack parameter is deprecated."
Closed, ResolvedPublic1 Estimated Story Points

Description

MediaModeration CI is currently broken with the following error:

00:06:37 There were 4 warnings:
00:06:37 
00:06:37 1) MediaWiki\Extension\MediaModeration\Tests\Unit\Services\MediaModerationFileLookupTest::testGetFileObjectsForSha1 with data set "No rows in the batches" (array(array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false)), 0)
00:06:37 Passing an argument of type Generator for the $haystack parameter is deprecated. Support for this will be removed in PHPUnit 10.
00:06:37 
00:06:37 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
00:06:37 
00:06:37 2) MediaWiki\Extension\MediaModeration\Tests\Unit\Services\MediaModerationFileLookupTest::testGetFileObjectsForSha1 with data set "One table with one row" (array(array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false)), 1)
00:06:37 Passing an argument of type Generator for the $haystack parameter is deprecated. Support for this will be removed in PHPUnit 10.
00:06:37 
00:06:37 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
00:06:37 
00:06:37 3) MediaWiki\Extension\MediaModeration\Tests\Unit\Services\MediaModerationFileLookupTest::testGetFileObjectsForSha1 with data set "All tables have one row" (array(array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false)), 3)
00:06:37 Passing an argument of type Generator for the $haystack parameter is deprecated. Support for this will be removed in PHPUnit 10.
00:06:37 
00:06:37 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
00:06:37 
00:06:37 4) MediaWiki\Extension\MediaModeration\Tests\Unit\Services\MediaModerationFileLookupTest::testGetFileObjectsForSha1 with data set "All tables have one more than one batch" (array(array(Wikimedia\Rdbms\FakeResultWrapper Object (...), '1234'), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), '1234'), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), '123456'), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), '1234'), array(Wikimedia\Rdbms\FakeResultWrapper Object (...), false)), 7)
00:06:37 Passing an argument of type Generator for the $haystack parameter is deprecated. Support for this will be removed in PHPUnit 10.
00:06:37 
00:06:37 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
00:06:37 
00:06:37 WARNINGS!
00:06:37 Tests: 17434, Assertions: 193443, Warnings: 4, Skipped: 9.

Event Timeline

Change 1010855 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010855

Change 1010855 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010855

Change 1010575 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.21] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010575

Change 1010576 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.22] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010576

Change 1010575 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.21] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010575

Change 1010576 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.22] Use iterator_to_array when calling ::assertCount

https://gerrit.wikimedia.org/r/1010576

Mentioned in SAL (#wikimedia-operations) [2024-03-13T13:25:17Z] <dreamyjazz@deploy2002> Started scap: Backport for [[gerrit:1010575|Use iterator_to_array when calling ::assertCount (T360017)]], [[gerrit:1010576|Use iterator_to_array when calling ::assertCount (T360017)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-13T13:27:35Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:1010575|Use iterator_to_array when calling ::assertCount (T360017)]], [[gerrit:1010576|Use iterator_to_array when calling ::assertCount (T360017)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-13T13:38:18Z] <dreamyjazz@deploy2002> Finished scap: Backport for [[gerrit:1010575|Use iterator_to_array when calling ::assertCount (T360017)]], [[gerrit:1010576|Use iterator_to_array when calling ::assertCount (T360017)]] (duration: 13m 01s)