AttributeError: 'GerritMessageBuilder' object has no attribute 'esc'
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	taavi
	Mar 13 2024, 3:03 PM

Description

2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z wikibugs2.gerrit DEBUG: processed: {"type": "PS1", "user": "Yaron Koren", "message": "Version 3.5.1", "repo": "mediawiki/extensions/Cargo", "branch": "master", "url": "https://gerrit.wikimedia.org/r/1010582", "task": null}
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0, chan=0] Closing channel
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0, chan=0] Received channel close
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0, chan=0] Channel closed
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0] Closing connection
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0] Sending disconnect: Disconnected by application (11)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] 2024-03-13T15:02:38Z asyncssh INFO: [conn=0] Connection closed
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] Traceback (most recent call last):
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return _run_code(code, main_globals, None,
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     exec(code, run_globals)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/__main__.py", line 9, in <module>
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     wikibugs2()
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return self.main(*args, **kwargs)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1078, in main
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     rv = self.invoke(ctx)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return _process_result(sub_ctx.command.invoke(sub_ctx))
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return ctx.invoke(self.callback, **ctx.params)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 783, in invoke
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return __callback(*args, **kwargs)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/decorators.py", line 33, in new_func
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return f(get_current_context(), *args, **kwargs)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/cli.py", line 85, in gerrit
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return gerrit_main(verbosity=ctx.obj["VERBOSE"])
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/gerrit.py", line 282, in main
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     asyncio.run(async_main(verbosity))
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/usr/lib/python3.9/asyncio/runners.py", line 44, in run
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return loop.run_until_complete(main)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     return future.result()
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/gerrit.py", line 244, in async_main
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     msg = builder.build_message(processed)
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/messagebuilder.py", line 146, in build_message
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x]     msg.text(" ", self.esc(event["message"]))
2024-03-13T15:02:38+00:00 [gerrit-6579d9d999-jms8x] AttributeError: 'GerritMessageBuilder' object has no attribute 'esc'

Details

	Title	Reference	Author	Source Branch	Dest Branch
	GerritMessageBuilder: add much needed output tests	toolforge-repos/wikibugs2!19	bd808	work/bd808/T360038	main
	GerritMessageBuilder: fix `self` reference missed in refactor	toolforge-repos/wikibugs2!18	bd808	work/bd808/T360038	main

Customize query in GitLab

Related Objects

Mentioned Here: rTWBTfa4fbd54441d: GerritMessageBuilder: fix more broken `self` references
rTWBT82caa471ccf6: GerritMessageBuilder: fix `self` reference missed in refactor

Event Timeline

taavi created this task.Mar 13 2024, 3:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2024, 3:03 PM

bd808 changed the task status from Open to In Progress.Mar 13 2024, 4:00 PM

bd808 claimed this task.

bd808 triaged this task as High priority.

bd808 changed the subtype of this task from "Task" to "Bug Report".

bd808 moved this task from Backlog to Doing on the Wikibugs board.

Restricted Application added a project: User-bd808. · View Herald TranscriptMar 13 2024, 4:00 PM

bd808 opened https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/18

GerritMessageBuilder: fix self reference missed in refactor

bd808 merged https://gitlab.wikimedia.org/toolforge-repos/wikibugs2/-/merge_requests/18

GerritMessageBuilder: fix self reference missed in refactor

Mentioned in SAL (#wikimedia-cloud) [2024-03-13T16:08:04Z] <wmbot~bd808@tools-sgebastion-11> Restared gerrit task to pick up 82caa471 fix for T360038

Slow down and read the code Bryan. :((

[pod/gerrit-6579d9d999-g7bl7/job] Traceback (most recent call last):
[pod/gerrit-6579d9d999-g7bl7/job]   File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
[pod/gerrit-6579d9d999-g7bl7/job]     return _run_code(code, main_globals, None,
[pod/gerrit-6579d9d999-g7bl7/job]   File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
[pod/gerrit-6579d9d999-g7bl7/job]     exec(code, run_globals)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/__main__.py", line 9, in <module>
[pod/gerrit-6579d9d999-g7bl7/job]     wikibugs2()
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
[pod/gerrit-6579d9d999-g7bl7/job]     return self.main(*args, **kwargs)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1078, in main
[pod/gerrit-6579d9d999-g7bl7/job]     rv = self.invoke(ctx)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
[pod/gerrit-6579d9d999-g7bl7/job]     return _process_result(sub_ctx.command.invoke(sub_ctx))
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
[pod/gerrit-6579d9d999-g7bl7/job]     return ctx.invoke(self.callback, **ctx.params)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/core.py", line 783, in invoke
[pod/gerrit-6579d9d999-g7bl7/job]     return __callback(*args, **kwargs)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/venv-wikibugs2-39/lib/python3.9/site-packages/click/decorators.py", line 33, in new_func
[pod/gerrit-6579d9d999-g7bl7/job]     return f(get_current_context(), *args, **kwargs)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/cli.py", line 85, in gerrit
[pod/gerrit-6579d9d999-g7bl7/job]     return gerrit_main(verbosity=ctx.obj["VERBOSE"])
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/gerrit.py", line 282, in main
[pod/gerrit-6579d9d999-g7bl7/job]     asyncio.run(async_main(verbosity))
[pod/gerrit-6579d9d999-g7bl7/job]   File "/usr/lib/python3.9/asyncio/runners.py", line 44, in run
[pod/gerrit-6579d9d999-g7bl7/job]     return loop.run_until_complete(main)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
[pod/gerrit-6579d9d999-g7bl7/job]     return future.result()
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/gerrit.py", line 244, in async_main
[pod/gerrit-6579d9d999-g7bl7/job]     msg = builder.build_message(processed)
[pod/gerrit-6579d9d999-g7bl7/job]   File "/data/project/wikibugs/wikibugs2/src/wikibugs2/messagebuilder.py", line 158, in build_message
[pod/gerrit-6579d9d999-g7bl7/job]     msg.text(" - ", *self.fmta(event["url"], fg=Color.TEAL))
[pod/gerrit-6579d9d999-g7bl7/job] AttributeError: 'GerritMessageBuilder' object has no attribute 'fmta'

Mentioned in SAL (#wikimedia-cloud) [2024-03-13T16:18:32Z] <wmbot~bd808@tools-sgebastion-11> Restared gerrit task to pick up fa4fbd54 fix for T360038