Fix Adyen failmail that is due to missing property in the response
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Damilare
	Mar 18 2024, 1:53 PM

Description

We get this failmail on some recurring transactions, seems it's due to a missing property:

Undefined index: details @ /srv/www/org/wikimedia/listeners/SmashPig/PaymentProviders/Adyen/PaymentProvider.php:182

We need to add a checker before the property is accessed.

	Subject	Repo	Branch	Lines +/-
	Add checks for getPaymentDetails function	wikimedia/fundraising/SmashPig	master	+64 -45

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 1012377 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[wikimedia/fundraising/SmashPig@master] Add checks for getPaymentDetails function

AKanji-WMF triaged this task as Medium priority.Mar 18 2024, 8:02 PM

Change 1012377 abandoned by Damilare Adedoyin:

[wikimedia/fundraising/SmashPig@master] Add checks for getPaymentDetails function

Reason:

Already worked on in a separate patch

XenoRyet closed this task as Resolved.Mar 25 2024, 7:21 PM

XenoRyet set Final Story Points to 2.