Migrate raw SQL building in conditions to expression builder in core
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Ladsgroup
	Mar 26 2024, 3:04 PM

Description

Now T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is mostly done, devs should start migrating their codebases away from building raw SQL.

See below as examples of adoption:

Also these regexes can migrate simple cases:

'([A-Za-z_\.]+) ?(=|!=|<|<=|>|>=) ?' . (\$db(?:r|w|))->addQuotes\( (.+?) \)
to:
$3->expr\( '$1', '$2', $4 \)

and

'([A-Za-z_\.]+) IS NULL OR ([A-Za-z_\.]+) ?(=|!=|<|<=|>|>=) ?' . (\$db(?:r|w|))->addQuotes\( (.+?) \)
to:
$4->expr( '$1', '=', null )->or\( '$2', '$3', $5 \)

Details

	Subject	Repo	Branch	Lines +/-
	Migrate several more raw SQL building to expression builders	mediawiki/core	master	+13 -489

Customize query in gerrit

Related Objects

Mentioned Here: T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.)

Event Timeline

Ladsgroup created this task.Mar 26 2024, 3:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2024, 3:04 PM

Change #1014531 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Migrate several more raw SQL building to expression builders

https://gerrit.wikimedia.org/r/1014531

gerritbot added a project: Patch-For-Review.Mar 26 2024, 3:18 PM

Change #1014531 merged by jenkins-bot: