Page MenuHomePhabricator

Move TMH file leaves behind m3u8 file
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Take a file with transcodes (assuming hls is on)
  • Move the file

What happens?:

  • The transcodes are deleted via WebVideoTranscode::removeTranscodes()
  • Which for the last step has updateStreamingManifests()
  • updateStreamingManifests always writes the main .m3u8 file
  • the transcode directory of the no longer existing file cannot be deleted.

What should have happened instead?:
updateStreamingManifests should not have written an m3u8 when deleting ALL transcodes.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1018353 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Do not leave main m3u8 file behind after delete

Change #1018353 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Do not leave main m3u8 file behind after delete