Page MenuHomePhabricator
Create Task
Maniphest T361766

c0cee4f78f12d6266578f0c7071bdc399fbc7b62 reduced overall test coverage
Open, LowPublic
Actions

Description

rCSSSc0cee4f78f12: Handle custom properties in color attributes for T360562: CSS sanitizer should support using CSS variables (not setting/creating them) for use in color values in TemplateStyles isn't seen as being covered at all at https://doc.wikimedia.org/cover/css-sanitizer/Grammar/CustomPropertyMatcher.php.html

Screenshot 2024-04-04 at 00.21.14.png (287×2 px, 66 KB)

Screenshot 2024-04-03 at 23.16.55.png (776×2 px, 220 KB)

Screenshot 2024-04-03 at 23.16.49.png (899×2 px, 200 KB)

Details

SubjectRepoBranchLines +/-
Cover test cases for CustomPropertyMatchercss-sanitizermaster+64 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Apr 3 2024, 11:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2024, 11:22 PM
Reedy triaged this task as Low priority.Apr 3 2024, 11:22 PM
gerritbot added a comment.Apr 4 2024, 9:47 AM

Change #1016380 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[css-sanitizer@master] Cover test cases for CustomPropertyMatcher

https://gerrit.wikimedia.org/r/1016380

gerritbot added a project: Patch-For-Review.Apr 4 2024, 9:47 AM
gerritbot added a comment.Apr 5 2024, 12:38 PM

Change #1016380 merged by jenkins-bot:

[css-sanitizer@master] Cover test cases for CustomPropertyMatcher

https://gerrit.wikimedia.org/r/1016380

Restricted Repository Identity mentioned this in rCSSS8b7b42587c1d: Cover test cases for CustomPropertyMatcher.Apr 5 2024, 12:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL