Page MenuHomePhabricator

[builds-api] replace all error message models with ResponseMessages
Closed, ResolvedPublic

Description

we have a number of error message models right now like InternalError{}, Conflict{}, NotFound{} and they are all used the same way return <error code>, <model>{Message: "this is a message"}.
These models don't really help much since <error code> is already communicating the type of error is being returned.
We should replace these models with the newly added and more generic ResponseMessages{}

Details

TitleReferenceAuthorSource BranchDest Branch
builds-api: bump to 0.0.143-20240415191619-ae83a3bcrepos/cloud/toolforge/toolforge-deploy!260project_1317_bot_df3177307bed93c3f34e421e26c86e38bump_builds-apimain
d/changelog: bump to 0.0.15repos/cloud/toolforge/builds-cli!63raymond-ndibebump_versionmain
[builds-api] refactor error responsesrepos/cloud/toolforge/builds-api!85raymond-ndibeconsolidate_error_modelsupdate_oapi_codegen
[builds-cli] refactor error responsesrepos/cloud/toolforge/builds-cli!61raymond-ndiberefactor_error_responsesmain
Customize query in GitLab

Event Timeline

dcaro triaged this task as High priority.Apr 5 2024, 12:09 PM
Raymond_Ndibe changed the task status from Open to In Progress.Apr 9 2024, 10:57 PM

project_1317_bot_df3177307bed93c3f34e421e26c86e38 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/260

builds-api: bump to 0.0.143-20240415191619-ae83a3bc