Page MenuHomePhabricator

Collapse appearance menu into three dot menu
Closed, DeclinedPublic

Description

Background

  • To avoid cluttering the experience for logged-out users, we would like to collapse the appearance menu into the three dot menu, thus avoiding introducing an icon for logged-out users

User story

  • As a reader, I want my tools to be in one menu, so that I can find them easily

Requirements

  • When pinned, menu should collapse into the three dot menu
  • Menu must be usable from the three dot menu
  • Default state of the menu should be open

Design

From design spec there:

Logged out

Reading theme settings anons.png (922×1 px, 345 KB)

Logged-out, hidden

Reading theme anons hidden.png (922×1 px, 336 KB)

Logged-out, unhide

Reading theme anons unhide.png (922×1 px, 354 KB)

Acceptance criteria

  • Complete all requirements
  • Check with @EBlackorby-WMF before merging. If we finish this after the menu deployment, we'd want to add a technews notice at the least
  • Since we support anonymous users on Polish Wikipedia, we will need to support cached HTML as well as the new design.

Communication criteria - does this need an announcement or discussion?

  • see above

Event Timeline

Jdlrobson subscribed.

We may want to re-estimate this based on impact on cached HTML.

Meeting notes: putting back to needs analysis to investigate caching implications.

Jdrewniak added a subscriber: bwang.
Jdlrobson removed the point value 5 for this task.Jul 25 2024, 11:43 PM

This needs a new estimate as this is a very different task now that we need to consider cached HTML.

With cached HTML we would need to include extra CSS to hide the original appearance button, and add JS to move the menu into the existing 3 dots menu. this would be temporary code.
In addition to that, we would need to make custom JS for moving the appearance menu similar to the TOC, now that we can no longer rely on the default "collapsible menu" logic

Jdlrobson lowered the priority of this task from High to Medium.Sep 13 2024, 4:48 PM

Lowering priority since this project is finished.

Still not a priority for this upcoming quarter, but worth us re-evaluating at some point soonish

Note from Justin: it's not great that we have an additional icon in this area

Assuming this lingering task with no active project tags is about the Vector 2022 codebase. Please add codebase project tags to tasks.

GIven that the team priorities (and Reader teams themselves) have shifted, I'm going to decline this task due to the complexity of the menu system as @bwang outlined above, and the maintenance overhead that this would incur without a more generalized way of handling these types of menu modifications.