Page MenuHomePhabricator
Create Task
Maniphest T362631

Output static page title language strings in static template
Open, Needs TriagePublic1 Estimated Story Points
Actions

Description

Currently on the front end the code has no way of knowing the language string of the current page to insert into the page title. This should be output as part of the static page template.

Acceptance Criteria

  • Launguage item for the current static page should be output as a data attribule alongside the page id and heading.

Event Timeline

AbbanWMDE created this task.Tue, Apr 16, 10:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 16, 10:06 AM
AbbanWMDE claimed this task.Tue, Apr 16, 10:07 AM
AbbanWMDE moved this task from Accessibility Improvements to Current Sprint on the WMDE-Fundraising-Tech board.
AbbanWMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2024-04-09 board.
AbbanWMDE removed AbbanWMDE as the assignee of this task.Thu, Apr 18, 5:44 AM
AbbanWMDE moved this task from Doing to Todo on the WMDE-FUN-Sprint-2024-04-09 board.
AbbanWMDE added a comment.Fri, Apr 19, 4:51 AM

PR: https://github.com/wmde/fundraising-application/pull/2953

AbbanWMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2024-04-09 board.Fri, Apr 19, 4:51 AM

Adding the page titles to the messages allows the static pages to get their titles using the data-page-id attribute: pageTitle: staticPage.getAttribute( 'data-page-id' )

gabriel-wmde moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2024-04-09 board.Mon, Apr 22, 9:46 AM
CorinnaHillebrand_WMDE subscribed.Mon, Apr 22, 12:26 PM

deployed (main/page-titles-in-messages ) to https://testing02.wikimedia.customers.manitu.net/

CorinnaHillebrand_WMDE moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2024-04-09 board.Mon, Apr 22, 12:26 PM
gabriel-wmde set the point value for this task to 2.Tue, Apr 23, 9:55 AM
CorinnaHillebrand_WMDE added a project: WMDE-FUN-Sprint-2024-04-23.Tue, Apr 23, 10:01 AM
gabriel-wmde moved this task from Todo to Doing on the WMDE-FUN-Sprint-2024-04-23 board.Tue, Apr 23, 10:03 AM
CorinnaHillebrand_WMDE moved this task from Doing to Test on the WMDE-FUN-Sprint-2024-04-23 board.Tue, Apr 23, 10:05 AM
gabriel-wmde changed the point value for this task from 2 to 1.Tue, Apr 23, 10:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL