gabriel-wmde (Gabriel Birke)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 2 2015, 1:34 PM (127 w, 6 d)
Availability
Available
IRC Nick
chiborg
LDAP User
Unknown
MediaWiki User
Gabriel Birke (WMDE)

Recent Activity

Today

gabriel-wmde moved T182796: Infobox is in the wrong place when payment type is BEZ from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Wed, Dec 13, 5:02 PM · WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2, WMDE-Fun-Team
gabriel-wmde updated subscribers of T182796: Infobox is in the wrong place when payment type is BEZ.

PR is at https://github.com/wmde/FundraisingFrontend/pull/1110

Wed, Dec 13, 5:02 PM · WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2, WMDE-Fun-Team
gabriel-wmde moved T182796: Infobox is in the wrong place when payment type is BEZ from Backlog to Doing on the WMDE-Fundraising-Funban-2 board.
Wed, Dec 13, 4:58 PM · WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2, WMDE-Fun-Team
gabriel-wmde created T182796: Infobox is in the wrong place when payment type is BEZ.
Wed, Dec 13, 4:39 PM · WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2, WMDE-Fun-Team
gabriel-wmde moved T182474: Payment types have no icons (Except Lastschrift) from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Wed, Dec 13, 4:25 PM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde added a comment to T182474: Payment types have no icons (Except Lastschrift).

PR is up https://github.com/wmde/FundraisingFrontend/pull/1109

Wed, Dec 13, 4:25 PM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde created T182790: Infobox scroll position is does not include status bar on mobile.
Wed, Dec 13, 3:49 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2

Yesterday

gabriel-wmde closed T182126: Review cat17 donation comment form UI as Resolved.

If you remove the main element from the cat17 template, it looks exactly as specified by the 3rd party.

Tue, Dec 12, 6:43 PM · WMDE-Fundraising-Funban-2
gabriel-wmde reassigned T182474: Payment types have no icons (Except Lastschrift) from gabriel-wmde to kai.nissen.
Tue, Dec 12, 6:08 PM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde added a comment to T182298: display after deleting the previously entered bank details.

I can't reproduce in this order, I can only reproduce it by deleting in the order IBAN, BIC, account number, bank code.

Tue, Dec 12, 6:07 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde created T182701: Make bank data validation behave consistently.
Tue, Dec 12, 5:50 PM · WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2, WMDE-Fun-Team
gabriel-wmde claimed T182405: Different handling postcode field.
Tue, Dec 12, 4:37 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182405: Different handling postcode field from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 4:36 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182302: Wrong amount shown at the confirmation page - comma from Doing to Backlog on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 4:35 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde reassigned T182302: Wrong amount shown at the confirmation page - comma from gabriel-wmde to kai.nissen.

The membership_fee field in the database is of type INT(11), which means the decimal amount will be silently dropped. Since changing the amount type might have also effects on the export, I'd say we postpone the feature "allow decimal membership fees" (or ditch it) and adapt the UI for the time being, meaning disallowing decimal points. Do you agree, @kai.nissen?

Tue, Dec 12, 4:34 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182302: Wrong amount shown at the confirmation page - comma.
Tue, Dec 12, 4:26 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182671: Sticky button container is too big on mobile from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 3:58 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde placed T182671: Sticky button container is too big on mobile up for grabs.
Tue, Dec 12, 3:58 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde added a comment to T182671: Sticky button container is too big on mobile.

Solved in https://github.com/wmde/FundraisingFrontend/pull/1105

Tue, Dec 12, 3:57 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde moved T182301: Prevent wrapping of amount and currency in summary sections from Backlog to Review on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 3:32 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182301: Prevent wrapping of amount and currency in summary sections.

Linebreak is avoided in https://github.com/wmde/FundraisingFrontend/pull/1104, but the preview now looks different.

Tue, Dec 12, 3:31 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182671: Sticky button container is too big on mobile.
Tue, Dec 12, 2:25 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde moved T182671: Sticky button container is too big on mobile from Backlog to Doing on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 2:25 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde placed T182423: nachträgliche Anpassung Bankdaten up for grabs.
Tue, Dec 12, 1:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182423: nachträgliche Anpassung Bankdaten from Backlog to Test on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 1:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde updated subscribers of T182474: Payment types have no icons (Except Lastschrift).

Adding the icons looks bad on mobile because they don't fit when the payment type description is long, so I'd say for consistency we remove the one for direct debit (which at the moment is only shown if the bank data is invalid).

Tue, Dec 12, 1:42 PM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde added a project to T182671: Sticky button container is too big on mobile: WMDE-Fundraising-Tech.
Tue, Dec 12, 12:28 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde created T182671: Sticky button container is too big on mobile.
Tue, Dec 12, 12:28 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech, WMDE-Fundraising-Funban-2
gabriel-wmde claimed T182474: Payment types have no icons (Except Lastschrift).
Tue, Dec 12, 11:59 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde moved T182474: Payment types have no icons (Except Lastschrift) from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 11:59 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde added a comment to T180042: Add house number validation to cat17.

Added warning to cat17 membership form in https://github.com/wmde/FundraisingFrontend/pull/1102

Tue, Dec 12, 11:46 AM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T180042: Add house number validation to cat17 from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 12, 11:45 AM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Mon, Dec 11

gabriel-wmde placed T182422: Amount is set back to 0,00 € up for grabs.
Mon, Dec 11, 7:09 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182422: Amount is set back to 0,00 € from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Mon, Dec 11, 7:09 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182400: The button “Jetzt Mitglied werden” is not working from Ready to Review on the WMDE-Fundraising-Funban-2 board.
Mon, Dec 11, 7:09 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182400: The button “Jetzt Mitglied werden” is not working.

I've tried setting the display value of the info-detail elements to none in PR https://github.com/wmde/FundraisingFrontend/pull/1100

Mon, Dec 11, 7:09 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde updated the task description for T180042: Add house number validation to cat17.
Mon, Dec 11, 7:00 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde placed T180042: Add house number validation to cat17 up for grabs.
Mon, Dec 11, 6:59 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182423: nachträgliche Anpassung Bankdaten.

CSS changes are in https://github.com/wmde/FundraisingFrontend/pull/1098, no markup changes though, as the error messages are part of the form markup.

Mon, Dec 11, 6:44 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T180042: Add house number validation to cat17.

This is the form with the warning in the (presumably) wrong color (and still bad positioning):

Mon, Dec 11, 11:35 AM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182422: Amount is set back to 0,00 €.
Mon, Dec 11, 10:19 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182422: Amount is set back to 0,00 € from Backlog to Doing on the WMDE-Fundraising-Funban-2 board.
Mon, Dec 11, 10:19 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182423: nachträgliche Anpassung Bankdaten.

Changed in https://github.com/wmde/fundraising-frontend-content/commit/dabcd29d51fe7e2279658eb058ecfafc8f6b18b9

Mon, Dec 11, 10:17 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182098: Adapt membership summary bar to mobile from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Mon, Dec 11, 10:09 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde placed T182098: Adapt membership summary bar to mobile up for grabs.
Mon, Dec 11, 10:09 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182126: Review cat17 donation comment form UI.

It's probably because the CSS for the comment form is not applied. When I did the cancellation pages yesterday I saw that you have to add a page- prefix to the CSS moved from page.scss to its own file. I was not away of that when I gave the introduction. See http://artesansatwork.com/wikimedia/comment-write.html on how it's supposed to look.

Mon, Dec 11, 8:39 AM · WMDE-Fundraising-Funban-2

Sun, Dec 10

gabriel-wmde placed T182435: Process for membership cancellations not working yet up for grabs.
Sun, Dec 10, 7:19 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182435: Process for membership cancellations not working yet from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Sun, Dec 10, 7:18 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182435: Process for membership cancellations not working yet.

Pull Request is up at https://github.com/wmde/FundraisingFrontend/pull/1095

Sun, Dec 10, 5:59 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182435: Process for membership cancellations not working yet.
Sun, Dec 10, 4:43 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182435: Process for membership cancellations not working yet from Backlog to Doing on the WMDE-Fundraising-Funban-2 board.
Sun, Dec 10, 4:43 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde removed a project from T182434: Process for donation cancellations not working yet : WMDE-Fundraising-Sprint-13.
Sun, Dec 10, 4:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182434: Process for donation cancellations not working yet from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Sun, Dec 10, 4:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde placed T182434: Process for donation cancellations not working yet up for grabs.
Sun, Dec 10, 4:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182434: Process for donation cancellations not working yet .

PR is up at https://github.com/wmde/FundraisingFrontend/pull/1094

Sun, Dec 10, 4:42 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182434: Process for donation cancellations not working yet .
Sun, Dec 10, 4:20 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182434: Process for donation cancellations not working yet from Backlog to Doing on the WMDE-Fundraising-Funban-2 board.
Sun, Dec 10, 4:20 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde closed T181276: mobile device - KONTAKT button text is missing as Resolved.

This is now resolved.

Sun, Dec 10, 4:19 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde closed T181276: mobile device - KONTAKT button text is missing, a subtask of T177936: contact form - Integrate new layout, as Resolved.
Sun, Dec 10, 4:19 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T181276: mobile device - KONTAKT button text is missing from Ready to Done on the WMDE-Fundraising-Funban-2 board.
Sun, Dec 10, 4:19 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Sat, Dec 9

gabriel-wmde updated the task description for T182476: Remaining issues for cat17 layout.
Sat, Dec 9, 12:31 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
gabriel-wmde renamed T182476: Remaining issues for cat17 layout from Remaining issues for to Remaining issues for cat17 layout.
Sat, Dec 9, 12:28 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
gabriel-wmde created T182476: Remaining issues for cat17 layout.
Sat, Dec 9, 12:28 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
gabriel-wmde reassigned T182408: "Spende abschließen" remains blocked after changing to new payment method from Pablo-WMDE to Jan_Dittrich.
Sat, Dec 9, 12:18 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182410: icons at "Übersicht".

Will be resolved with https://github.com/wmde/FundraisingFrontend/pull/1085 which introcuces amount validatioin independently from payment type. However, even then payment type icons only shows up for Lastschrift. I've created issue for that: T182474

Sat, Dec 9, 12:10 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a parent task for T182474: Payment types have no icons (Except Lastschrift): T177929: Integrate new layout.
Sat, Dec 9, 12:08 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde added a subtask for T177929: Integrate new layout: T182474: Payment types have no icons (Except Lastschrift).
Sat, Dec 9, 12:08 AM · WMDE-Fun-Team, Epic, WMDE-Fundraising-Tech
gabriel-wmde created T182474: Payment types have no icons (Except Lastschrift).
Sat, Dec 9, 12:07 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team, WMDE-Fundraising-Funban-2
gabriel-wmde merged task T182413: supporters list not displayed correctly into T179938: Unterstützerliste style.
Sat, Dec 9, 12:04 AM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde merged T182413: supporters list not displayed correctly into T179938: Unterstützerliste style.
Sat, Dec 9, 12:04 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Fri, Dec 8

gabriel-wmde reassigned T182417: Wechseln zwischen Bezahlmethoden - iPhone 5s from Pablo-WMDE to Jan_Dittrich.

Issue is solved/ not reproducible for bank data.

Fri, Dec 8, 11:53 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde reassigned T182418: IBAN overlapping from Pablo-WMDE to Jan_Dittrich.

This happens only on very small devices (<350px). Should we add a special breakpoint for this field that reduces the font size a bit? Or just leave it, as the number is still readable?

Fri, Dec 8, 11:38 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde reassigned T182423: nachträgliche Anpassung Bankdaten from Pablo-WMDE to Jan_Dittrich.

I'd say "works as designed", but maybe the design is not properly conveyed: If the user edits oldfashioned bank data, the IBAN/BIC is updated (if the ban code is valid), If the user edits IBAN, the bank data is updated (if the IBAN is valid). We don't have error message to tell the user what's wrong (invalid IBAN, invalid bank code), only that an error occured. I guess in the description above the bank ocde or the IBAN checksum were incorrect. Any idea on how this could be improved?

Fri, Dec 8, 11:30 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde reassigned T182425: Switch from Privat to Firma from Pablo-WMDE to Jan_Dittrich.

What do you think, @Jan_Dittrich ? Which address type transitions should trigger an "invalid" state for empty address fields, if at all? only privat->firma, firma->privat or also anonymous? Only check the fields that are different (company name vs person fields) or all fields? What if the form is partially filled? What if the address data is empty and only the the address type is switched?

Fri, Dec 8, 11:19 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T180690: Show summarizing sentence after entering the donation form from a deep-link.

@Jan_Dittrich : If we want to stay in the palette of the elements we already have and bot introduce new color values - which color values would you pick? Or do you want to explicitly introduce new color values?

Fri, Dec 8, 5:23 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T180690: Show summarizing sentence after entering the donation form from a deep-link from Doing to Review on the WMDE-Fundraising-Funban-2 board.
Fri, Dec 8, 4:54 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde reassigned T182422: Amount is set back to 0,00 € from Pablo-WMDE to Jan_Dittrich.

This happens when there are more than 2 numbers after the decimal point. My first reaction would be to truncate. Do you think that's ok, @Jan_Dittrich ,@kai.nissen?

Fri, Dec 8, 4:50 PM · WMDE-Fundraising-Funban-2, WMDE-Fundraising-Sprint-13, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T180690: Show summarizing sentence after entering the donation form from a deep-link.

New PR is up: https://github.com/wmde/FundraisingFrontend/pull/1090

Fri, Dec 8, 4:26 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T182098: Adapt membership summary bar to mobile.

Question for @Pablo-WMDE: I've extended FormDataExtractor to with the method mapFromRadioLabelsShort which can read the data-short-text attribute of labels. Now I see two options for integrating the texts in the form:

Fri, Dec 8, 12:10 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde claimed T182098: Adapt membership summary bar to mobile.
Fri, Dec 8, 11:23 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182098: Adapt membership summary bar to mobile from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
Fri, Dec 8, 11:23 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T181273: mobile device - button “Spende abschließen” is displayed twice.

Scrolling form parts into view has helped with part 2. I can reproduce the "duplicate form button" issue, but I'd say we rather have a duplicate button than no button through some weird egde case. Do you agree, @kai.nissen ?

Fri, Dec 8, 11:22 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T181273: mobile device - button “Spende abschließen” is displayed twice from Ready to Test on the WMDE-Fundraising-Funban-2 board.
Fri, Dec 8, 11:19 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Thu, Dec 7

gabriel-wmde reassigned T180690: Show summarizing sentence after entering the donation form from a deep-link from gabriel-wmde to kai.nissen.

After talking to @Jan_Dittrich and demonstrating the banner functionality on my machine, we saw other usability complexities with the "banner" approach. That means, the PR cannot be used and the functionality needs to be implemented differently, maybe with a different UX concept.

Thu, Dec 7, 5:22 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T180690: Show summarizing sentence after entering the donation form from a deep-link.

Instead of .scrollTop, could we use .animate with a 0-duration and complete callback where we attach the listeners for the hide-on-scroll?

Thu, Dec 7, 4:12 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech

Wed, Dec 6

gabriel-wmde updated subscribers of T180690: Show summarizing sentence after entering the donation form from a deep-link.

PR is up at https://github.com/wmde/FundraisingFrontend/pull/1080

Wed, Dec 6, 7:21 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde added a comment to T181982: Deeplink application for specific membership type.

The word "Fördermitgliedschaft" in the right summary (or top bar on mobile) is still clickable and scrolls up to an invisible element when clicked. Shouldn't this special case remove the clickability? Please advise, @kai.nissen @Jan_Dittrich

Wed, Dec 6, 10:11 AM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde assigned T182178: Show donation receipt opt-out in confirmation to kai.nissen.

Just thought of this, don't know if this is valid/important. Please advise, @kai.nissen

Wed, Dec 6, 9:53 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team
gabriel-wmde created T182178: Show donation receipt opt-out in confirmation.
Wed, Dec 6, 9:51 AM · WMDE-Fundraising-Tech, WMDE-Fun-Team

Tue, Dec 5

gabriel-wmde updated the task description for T180690: Show summarizing sentence after entering the donation form from a deep-link.
Tue, Dec 5, 3:12 PM · WMDE-Design (WMDE-Design-Workboard Doing), Design, WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde created T182098: Adapt membership summary bar to mobile.
Tue, Dec 5, 2:17 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde updated the task description for T182087: Integrate membership call-to-action on donation confirmation page.
Tue, Dec 5, 12:51 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182087: Integrate membership call-to-action on donation confirmation page from Ready to Backlog on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 5, 12:48 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde moved T182087: Integrate membership call-to-action on donation confirmation page from Backlog to Ready on the WMDE-Fundraising-Funban-2 board.
Tue, Dec 5, 12:48 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde updated the task description for T182087: Integrate membership call-to-action on donation confirmation page.
Tue, Dec 5, 12:47 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde created T182087: Integrate membership call-to-action on donation confirmation page.
Tue, Dec 5, 12:44 PM · WMDE-Fundraising-Funban-2, WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde updated the task description for T182075: Define unified URL schema for Fundraising Frontend.
Tue, Dec 5, 12:17 PM · Epic, WMDE-Fundraising-Tech, WMDE-Fun-Team
gabriel-wmde added a comment to T182081: Make membership cancellation a POST route.

Possibly related, but IMHO more important than T182075

Tue, Dec 5, 12:15 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde created T182081: Make membership cancellation a POST route.
Tue, Dec 5, 12:15 PM · WMDE-Fun-Team, WMDE-Fundraising-Tech
gabriel-wmde created T182075: Define unified URL schema for Fundraising Frontend.
Tue, Dec 5, 11:59 AM · Epic, WMDE-Fundraising-Tech, WMDE-Fun-Team