Mon, Apr 24
We've asked the WMF fundraising team if they have automated test in place and the response was more along the lines of analyzing impression data to detect if banners are not displayed.
Pitching in from WMDE Fundraising. Our tracking requirements are two-fold:
There is an approved PR for this (https://github.com/wmde/fundraising-backend/pull/253). However, the Travis build file where MySQL 5.6 is installed keeps breaking. Maybe we should go another route and use an external docker container instead? I'd need some help and expertise from @Pablo-WMDE for that.
A pull request is ready: https://github.com/wmde/FundraisingFrontend/pull/873
Fri, Apr 21
Added a PR to show how it can be done: https://github.com/wmde/FundraisingFrontend/pull/872
Thu, Apr 20
Deployed on test and prod
"Run PHPUnit and Browser tests to check if anything broke." is not enough for this task IMHO. We need to answer the following questions:
Do we want to run our tests in different locales?
All tests or only some?
If we do our tests independently from the locale, how to we test for assigned placeholders?
Results from checking the scripts directory:
Wed, Apr 19
Thu, Apr 13
Wed, Apr 12
First 2 steps are in https://github.com/wmde/fundraising-infrastructure/pull/113
Quick note: IMHO this is best implemented in a Silex pre-routing function.
Mon, Apr 10
Fri, Apr 7
As long as T162457 is not implemented (and it doesn't have as much priority as this epic), I'd say we don't use a long-lived feature branch for this but use a feature toggle in the configuration