If you remove the main element from the cat17 template, it looks exactly as specified by the 3rd party.
I can't reproduce in this order, I can only reproduce it by deleting in the order IBAN, BIC, account number, bank code.
The membership_fee field in the database is of type INT(11), which means the decimal amount will be silently dropped. Since changing the amount type might have also effects on the export, I'd say we postpone the feature "allow decimal membership fees" (or ditch it) and adapt the UI for the time being, meaning disallowing decimal points. Do you agree, @kai.nissen?
Linebreak is avoided in https://github.com/wmde/FundraisingFrontend/pull/1104, but the preview now looks different.
Adding the icons looks bad on mobile because they don't fit when the payment type description is long, so I'd say for consistency we remove the one for direct debit (which at the moment is only shown if the bank data is invalid).
Added warning to cat17 membership form in https://github.com/wmde/FundraisingFrontend/pull/1102
Mon, Dec 11
I've tried setting the display value of the info-detail elements to none in PR https://github.com/wmde/FundraisingFrontend/pull/1100
CSS changes are in https://github.com/wmde/FundraisingFrontend/pull/1098, no markup changes though, as the error messages are part of the form markup.
It's probably because the CSS for the comment form is not applied. When I did the cancellation pages yesterday I saw that you have to add a page- prefix to the CSS moved from page.scss to its own file. I was not away of that when I gave the introduction. See http://artesansatwork.com/wikimedia/comment-write.html on how it's supposed to look.
Sun, Dec 10
Pull Request is up at https://github.com/wmde/FundraisingFrontend/pull/1095
This is now resolved.
Sat, Dec 9
Will be resolved with https://github.com/wmde/FundraisingFrontend/pull/1085 which introcuces amount validatioin independently from payment type. However, even then payment type icons only shows up for Lastschrift. I've created issue for that: T182474
Fri, Dec 8
Issue is solved/ not reproducible for bank data.
This happens only on very small devices (<350px). Should we add a special breakpoint for this field that reduces the font size a bit? Or just leave it, as the number is still readable?
I'd say "works as designed", but maybe the design is not properly conveyed: If the user edits oldfashioned bank data, the IBAN/BIC is updated (if the ban code is valid), If the user edits IBAN, the bank data is updated (if the IBAN is valid). We don't have error message to tell the user what's wrong (invalid IBAN, invalid bank code), only that an error occured. I guess in the description above the bank ocde or the IBAN checksum were incorrect. Any idea on how this could be improved?
What do you think, @Jan_Dittrich ? Which address type transitions should trigger an "invalid" state for empty address fields, if at all? only privat->firma, firma->privat or also anonymous? Only check the fields that are different (company name vs person fields) or all fields? What if the form is partially filled? What if the address data is empty and only the the address type is switched?
@Jan_Dittrich : If we want to stay in the palette of the elements we already have and bot introduce new color values - which color values would you pick? Or do you want to explicitly introduce new color values?
New PR is up: https://github.com/wmde/FundraisingFrontend/pull/1090
Question for @Pablo-WMDE: I've extended FormDataExtractor to with the method mapFromRadioLabelsShort which can read the data-short-text attribute of labels. Now I see two options for integrating the texts in the form:
Scrolling form parts into view has helped with part 2. I can reproduce the "duplicate form button" issue, but I'd say we rather have a duplicate button than no button through some weird egde case. Do you agree, @kai.nissen ?
Thu, Dec 7
After talking to @Jan_Dittrich and demonstrating the banner functionality on my machine, we saw other usability complexities with the "banner" approach. That means, the PR cannot be used and the functionality needs to be implemented differently, maybe with a different UX concept.
Instead of .scrollTop, could we use .animate with a 0-duration and complete callback where we attach the listeners for the hide-on-scroll?
Wed, Dec 6
The word "Fördermitgliedschaft" in the right summary (or top bar on mobile) is still clickable and scrolls up to an invisible element when clicked. Shouldn't this special case remove the clickability? Please advise, @kai.nissen @Jan_Dittrich
Just thought of this, don't know if this is valid/important. Please advise, @kai.nissen
Tue, Dec 5
Possibly related, but IMHO more important than T182075