Now moved to 12:00
Sat, May 19
Presentation slides are available at https://docs.google.com/presentation/d/1s8oW3m0d2ExtdEkXFypgzls6biZ5savIjoE0vlmFb0U/edit?usp=sharing
Fri, May 18
Oh my, this is a major design change IMHO. We should get UX on board for that.
Wed, May 16
Tue, May 15
I'm a bit confused how this applies to AdvancedSearch, as the error message comes from the Translate extension. Is one of our translation strings too long? Can you describe what you did? Did you try two installs, one with and one without AdvancedSearch and the one with AdvancedSearch fails?
Wed, May 9
The link you provided is a very bad-looking plaintext file. Is there something better?
Here is a preview:
As it turns out, Nimblu gave us wrong information - the reboot did not work for freeing up the space, running sudo apt autoremove was the solution.
Tue, May 8
Fri, May 4
While the bug is fixed, one test in the donation repo is now failing (because it's testing too much). Work is done in https://github.com/wmde/fundraising-donations/pull/53
As this would involve somehow passing in SSH keys into the ansible image, it's kind of pointless.
Small followup for the template output: https://github.com/wmde/FundraisingFrontend/pull/1226
Added a small followup: https://github.com/wmde/fundraising-infrastructure/pull/208
I've added additional BIC validation to the bank data validation. As the BIC is autogenerated this should not lead to errors in most cases.
Possibly related: T193843: Update/Replace Gulp task runner for cat17 skin
Thu, May 3
The fix is in https://github.com/wmde/fundraising-payments/pull/8
@kai.nissen For foreign IBAN the BIC still is not a required field, right? Only the IBAN is required?
Wed, May 2
Added SWAT patch to calendar at https://wikitech.wikimedia.org/wiki/Deployments#Tuesday,_May_08
Fri, Apr 27
Context is now moved to https://github.com/wmde/fundraising-payments
There is now a repository, split from FundraisingFrontend, with a branch that adds testing and makes the context more standalone: https://github.com/wmde/fundraising-subscriptions/tree/split-from-frundraising-frontend
Thu, Apr 26
Tue, Apr 24
Mon, Apr 23
Merged the PR, tested the tracking with a local copy. This can now be deployed
Apr 20 2018
Pull request (WIP): https://github.com/wmde/fundraising-backend/pull/370
Apr 19 2018
@Tobias_Schumann_WMDE : The current patch will log the impressions as the fake "page" wpde-page-imp in spenden.wikimedia.de. Wouldn't it be more convenient an in line with Piwik if we tracked them as an access to wikipedia.de? We already have wikipedia.de as a possible tracking target URL in our Piwik.
Thank you for the introduction of the BankDataGenerator interface. With this, we avoid having to add the adapted Dockerfile with the KontoCheck PHP extension to the PaymentContext and can keep that messy thing in FundraisingFrontend, as you proposed. We'll only need it there.
Most of the space was freed by me running apt autoremove to remove unused linux kernels and Node.js
There was not much space claimed by volumes, the volume cleanup we introduced with https://github.com/wmde/fundraising-infrastructure/pull/198 worked fine.
Apr 17 2018
Apr 16 2018
@kai.nissen : I just stumbled upon our "hack" for enabling/disabling Sofortüberweisung with an URL parameter (https://github.com/wmde/FundraisingFrontend/blob/master/src/Presentation/SofortToggleServiceProvider.php), which is kind of an A/B in itself. I think we might need to adjust the acceptance criteria to not only encompass skin changes but also "custom feature toggles" where functionality can be turned on/off.
https://github.com/wmde/FundraisingFrontend/pull/1211 was a very good first step but introduced a small unwanted whitespace on the membership page, after the personal data section. This is caused by the height: 100% rule in the file layouts/_borders-system.sass. The comment in that file (/* only for donation form */) is no longer correct - the rules get applied on the membership page, which looks bad without them. Only the height: 100% property should be applied to the donation page.
Apr 12 2018
Apr 11 2018
Sorry that I did not raise this earlier (I just assumed that this was about making the text more readable), but the description is slightly wrong/more complex. As it is now, the word stemming is applied, if you don't put the words/phrases in quotes.