Page MenuHomePhabricator

Adapt PayPal configuration to have two return URLS
Open, Needs TriagePublic8 Estimated Story Points

Description

Implementation Details

  • Change PayPalPaymentProviderAdapterConfig (the class that contains the data from the PayPal API YAML configuration), deprecating (but not removing) returnUrl and adding returnUrlRecurring (it's the same as returnUrl) and returnUrlOneTime. Adapt the tests and PayPalPaymentProviderAdapterConfigSchema (the class that validates the array structure form the YAML).
  • Change the parameters in PayPalPaymentProviderAdapter to use returnUrlOneTime in the createOrderWithAPI method (with a fallback with a deprecation warning to returnUrl)
  • Adapt example configuration in config/paypal_api.example.yml
  • Adapt test configurations in tests/Data/PayPalAPIURLGeneratorConfig/ You need to change *all* configurations so the tests for the "broken" configurations don't fail for the wrong reasons