Page MenuHomePhabricator
Create Task
Maniphest T363785

Prevent ValidationError code collisions
Open, Needs TriagePublic
Actions

Description

We use error code strings to tell ValidationError objects apart. Some of those codes are identical across validators which led to some code only working by accident, and may cause bugs later on. We should make sure that those don't overlap.

Idea: add some kind of prefix to all error codes (and context keys), e.g. the class/interface name.

Details

SubjectRepoBranchLines +/-
REST: Rename validation constsmediawiki/extensions/Wikibasemaster+19 -19
REST: Rename validation consts for sitelinks and statementsmediawiki/extensions/Wikibasemaster+40 -38
REST: Rename descriptions validation constsmediawiki/extensions/Wikibasemaster+26 -26
REST: Rename labels validation constsmediawiki/extensions/Wikibasemaster+63 -51
REST: Rename aliases validation constsmediawiki/extensions/Wikibasemaster+58 -56
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Tue, Apr 30, 1:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 30, 1:13 AM
Muhammad_Yasser_Jazirahly_WMDE subscribed.Tue, Apr 30, 8:23 AM
Ollie.Shotton_WMDE subscribed.Tue, Apr 30, 9:30 AM
Ifrahkhanyaree_WMDE moved this task from Tech backlog to Ready for planning on the Wikibase Product Platform Team WPP board.Tue, Apr 30, 9:41 AM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 19 on the Wikibase Product Platform Team WPP board.Tue, Apr 30, 11:02 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 19); removed Wikibase Product Platform Team WPP.
Ifrahkhanyaree_WMDE added a project: Wikibase REST API (WPP).
gerritbot added a comment.Tue, Apr 30, 2:27 PM

Change #1025795 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename aliases validation consts

https://gerrit.wikimedia.org/r/1025795

gerritbot added a project: Patch-For-Review.Tue, Apr 30, 2:27 PM
Ifrahkhanyaree_WMDE moved this task from Backlog to Happening now on the Wikibase REST API (WPP) board.Tue, Apr 30, 3:06 PM
gerritbot added a comment.Mon, May 6, 2:46 AM

Change #1025795 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename aliases validation consts

https://gerrit.wikimedia.org/r/1025795

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Mon, May 6, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, May 6, 3:30 AM
Muhammad_Yasser_Jazirahly_WMDE claimed this task.Wed, May 8, 1:10 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 19) board.
gerritbot added a comment.Wed, May 8, 2:21 PM

Change #1029202 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename labels validation consts

https://gerrit.wikimedia.org/r/1029202

gerritbot added a project: Patch-For-Review.Wed, May 8, 2:21 PM
gerritbot added a comment.Wed, May 8, 2:38 PM

Change #1029208 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename descriptions validation consts

https://gerrit.wikimedia.org/r/1029208

gerritbot added a comment.Wed, May 8, 6:27 PM

Change #1029241 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename validation consts for sitelinks and statements

https://gerrit.wikimedia.org/r/1029241

gerritbot added a comment.Wed, May 8, 6:36 PM

Change #1029243 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename validation consts

https://gerrit.wikimedia.org/r/1029243

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 19) board.Wed, May 8, 7:00 PM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 20); removed Wikibase Product Platform Team WPP (Sprint 19).Wed, May 15, 10:49 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 20) board.
gerritbot added a comment.Wed, May 15, 4:30 PM

Change #1029202 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename labels validation consts

https://gerrit.wikimedia.org/r/1029202

gerritbot added a comment.Wed, May 15, 4:30 PM

Change #1029208 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename descriptions validation consts

https://gerrit.wikimedia.org/r/1029208

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Wed, May 15, 5:00 PM
gerritbot added a comment.Wed, May 15, 6:16 PM

Change #1029241 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename validation consts for sitelinks and statements

https://gerrit.wikimedia.org/r/1029241

gerritbot added a comment.Wed, May 15, 6:16 PM

Change #1029243 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename validation consts

https://gerrit.wikimedia.org/r/1029243

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 20) board.Wed, May 15, 6:20 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, May 15, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL