Page MenuHomePhabricator

Not all Growth tables are automatically created on all newly created Wikipedias
Closed, ResolvedPublic

Description

While deploying T364130: Enable Growth mentorship at igl.wikipedia.org, I ran createExtensionTables.php to ensure iglwiki has the necessary DB tables, and this was the output:

[urbanecm@mwmaint1002 ~]$ mwscript extensions/WikimediaMaintenance/createExtensionTables.php --wiki=iglwiki growthexperiments
Creating growthexperiments tables...
  growthexperiments_link_recommendations already exists
  growthexperiments_link_submissions already exists
  growthexperiments_mentee_data already exists
  growthexperiments_mentor_mentee already exists
  sourcing growthexperiments_user_impact.sql
  done!
[urbanecm@mwmaint1002 ~]$

This is not expected – wiki should either have all growth tables, or none of them. Inspection of MediaWiki-extensions-WikimediaMaintenance showed the last table is not listed in addWiki.php, while the rest of them are:

urbanecm@wmf3345 WikimediaMaintenance % git grep growthexperiments_user_impac
createExtensionTables.php:                                      'growthexperiments_user_impact' => 'growthexperiments_user_impact.sql',
urbanecm@wmf3345 WikimediaMaintenance % vim 
urbanecm@wmf3345 WikimediaMaintenance % git grep growthexperiments_mentor_mentee
addWiki.php:                            'growthexperiments_mentor_mentee.sql'
createExtensionTables.php:                                      'growthexperiments_mentor_mentee' => 'growthexperiments_mentor_mentee.sql',
urbanecm@wmf3345 WikimediaMaintenance %

Let's fix this...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1028450 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/WikimediaMaintenance@master] addWiki: Automatically create growthexperiments_user_impact on all new Wikipedias

https://gerrit.wikimedia.org/r/1028450

Change #1028450 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] addWiki: Automatically create growthexperiments_user_impact on all new Wikipedias

https://gerrit.wikimedia.org/r/1028450