Page MenuHomePhabricator

Fix validation affecting surveys with new schema
Closed, ResolvedPublic

Description

We have identified a couple of minor issues when using the new survey schema.

AC

  • Allow layout to be optional only if deprecated question field is in use.
  • Do not request a translation for the top-level question field if it is not in use.

Event Timeline

Amdrel changed the task status from Open to In Progress.May 6 2024, 8:59 PM

Change #1028601 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/QuickSurveys@master] T364346: Fix survey validation of top-level layout

https://gerrit.wikimedia.org/r/1028601

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/42ce80c18c/w

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a44d09140e/w

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/42ce80c18c/w/

Change #1037233 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/QuickSurveys@community-safety] Improve capability of QuickSurvey

https://gerrit.wikimedia.org/r/1037233

Change #1037233 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@community-safety] Improve capability of QuickSurvey

https://gerrit.wikimedia.org/r/1037233

Change #1028601 abandoned by Amdrel:

[mediawiki/extensions/QuickSurveys@master] T364346: Fix survey validation of top-level layout

Reason:

This patch has been cherry-picked and squashed into the following branch: https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/QuickSurveys+branch:community-safety+status:merged

https://gerrit.wikimedia.org/r/1028601

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a44d09140e/w/

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/1f5a200338/w

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1f5a200338/w/

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e606e11883/w

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0d85df7998/w

Test wiki on Patch demo by Amdrel using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/80286dd93e/w/

Test wiki on Patch demo by Amdrel using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7ed125994c/w/

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0d85df7998/w/