Page MenuHomePhabricator

Extend BGP peer automation via Netbox to include VMs
Closed, ResolvedPublic

Description

During the build-out of magru we realised that the work done under T306649 to automate building the BGP groups and peer IPs for our network equipment did not cover virtual machines.

The automation was done in a way which meant that existing configured peers were not removed when the static yaml for peers was deleted, but we are not generating the config for these currently. That meant in Magru we had to add manually, as well as set bgp=false in Netbox to prevent Homer trying to add the peerings to the CRs there (VMs should instead peer directly with the top-of-rack switch matching the ganeti cluster they're in).

Creating this task to track efforts to resolve this.

Event Timeline

cmooney triaged this task as Medium priority.May 8 2024, 3:02 PM
cmooney created this task.

Change #1029231 had a related patch set uploaded (by Cathal Mooney; author: Cathal Mooney):

[operations/software/homer/deploy@master] Support VM BGP automation using Netbox flag for L3 POPs

https://gerrit.wikimedia.org/r/1029231

Change #1029231 merged by Cathal Mooney:

[operations/software/homer/deploy@master] Support VM BGP automation using Netbox flag for L3 POPs

https://gerrit.wikimedia.org/r/1029231

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:06:44Z] <cmooney@cumin1002> START - Cookbook sre.deploy.python-code homer to cumin2002.codfw.wmnet,cumin1002.eqiad.wmnet with reason: Release v0.6.5 update to add modified wmf homer plugin - cmooney@cumin1002 - T364480

Deployed homer to cumin2002.codfw.wmnet,cumin1002.eqiad.wmnet with reason: Release v0.6.5 update to add modified wmf homer plugin - cmooney@cumin1002 - T364480

Mentioned in SAL (#wikimedia-operations) [2024-05-14T16:08:24Z] <cmooney@cumin1002> END (PASS) - Cookbook sre.deploy.python-code (exit_code=0) homer to cumin2002.codfw.wmnet,cumin1002.eqiad.wmnet with reason: Release v0.6.5 update to add modified wmf homer plugin - cmooney@cumin1002 - T364480

Patch to Homer wmf plugin merged now, so BGP to VMs at POPs / on L3 switches now under automation too.