Page MenuHomePhabricator

Special:Investigate ComparePager should display total actions for the IP instead of edits
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
May 14 2024, 10:05 PM
Referenced Files
F54011306: image.png
May 21 2024, 2:12 AM
F53998386: image.png
May 21 2024, 2:12 AM
F53996410: image.png
May 21 2024, 2:12 AM
Restricted File
May 20 2024, 10:34 AM
F53231439: image.png
May 14 2024, 10:05 PM


Special:Investigate 'IP & User agents' mode displays the total number of actions performed by the specific row (unique user, IP, and user agent combination), and also the number of actions performed by all users on that IP address. This is similar to the data displayed in Special:CheckUser 'Get IP Addresses' and is shown below:

image.png (77×468 px, 3 KB)

However, while the count is labelled with the word actions, the counts are inconsistent with each other and also are labelled incorrectly. The total actions by the specific row is the count of all log entries and edits (excluding StructuredDiscussions edits), but the total from the IP count is a count of only edits (excluding StructuredDiscussions edits). The restriction to specific actions seems relatively arbitrary, considering that the filtering out of StructuredDiscussions edits is not applied by the 'Timeline' mode.

Updating the code to remove the restriction of what actions are used to generate the count should reduce confusion and bring the meanings of this data inline with the meaning in Special:CheckUser.

Acceptance criteria
  • Remove the conditions on cuc_type in the 'IP & User agents' tab

Event Timeline

Change #1031578 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Include all actions for total actions count in the Compare tab

Change #1031578 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Include all actions for total actions count in the Compare tab

Suggested QA steps for patch demo:

  1. Login to an account
  2. Make an edit
  3. Move a page
  4. Log out of the account
  5. Login to a different account that has the checkuser group
  6. Move a page
  7. Open Special:Investigate and run a check on the account you logged into in step 2
  8. Verify that the actions count displayed in bold is 2 and that the number in italics is 3, as shown in the screenshot below:


These steps are testing that all events are included in the counts that are shown in this column (not just edits).

Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You for the QA Steps @Dreamy_Jazz!!!

image.png (563×1 px, 59 KB)

image.png (686×978 px, 155 KB)

image.png (481×1 px, 203 KB)

Dreamy_Jazz updated the task description. (Show Details)