Page MenuHomePhabricator

Better error handling for wikipedia-homepage
Open, Needs TriagePublic

Description

Errors of the type below happen quite frequently. They're probably because the API responded with some kind of error message.

ERROR:app:Exception on /suggest [GET]
Traceback (most recent call last):
  File "/srv/wikipedia.se/.venv/lib/python3.10/site-packages/flask/app.py", line
 2525, in wsgi_app
    response = self.full_dispatch_request()
  File "/srv/wikipedia.se/.venv/lib/python3.10/site-packages/flask/app.py", line
 1822, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/srv/wikipedia.se/.venv/lib/python3.10/site-packages/flask/app.py", line 1820, in full_dispatch_request
    rv = self.dispatch_request()
  File "/srv/wikipedia.se/.venv/lib/python3.10/site-packages/flask/app.py", line 1796, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/srv/wikipedia.se/app.py", line 93, in suggest
    suggestions = [p["title"] for p in response["query"]["allpages"]]
KeyError: 'query'