Page MenuHomePhabricator

Restore translations lost when libphutil was split
Closed, ResolvedPublic

Description

Until about 2020 there was a separate "libphutil-core" group in Phabricator translations. This was dismantled by upstream Phabricator circa 2020, with each message there being moved to a different group. Unfortunately, translatewiki.net was never made aware of this, so the translations were not moved.

The old libphutil translations should be checked and re-added to the messages in other groups if they haven't been translated already.

Event Timeline

Not sure if it's worth it. https://translatewiki.net/w/i.php?title=Special:Search&limit=500&offset=0&ns1274=1&search=libphutil-core claims there are ~6k messages and probably at least half of them are /en or /qqq or already translated again.

At the time it was deleted in rPHTRaf9ac6de1865cba010ef98e6054d3de79ece0e7a libphutil had 785 lines, which corresponds to 783 strings to translate. That leaves 4K true translations to review. Working on it.

More detailled output from my script:

256 translations into ca rescued
63 translations into ca could not be found
146 translations into da rescued
18 translations into da could not be found
0 translations into fr rescued
63 translations into fr could not be found
500 translations into tr rescued
63 translations into tr could not be found

Some of the ones that could not be found, in the happy-happy world in which this had been done properly, would have been found at the time and then there was a message key rename which I can't trace through years later. That's not worth doing automatically, but there are few enough I may do it manually on the translatewiki.net side (marking the messages with FUZZY)

Pasted the code I used for that script as P63840

Change #1037902 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Rescue libphutil translations

https://gerrit.wikimedia.org/r/1037902

Fate of all of the 63 strings that could not be found

No, that wasn't the most productive use of my time, but I like spelunking through old git history, and discovered https://we.phorge.it/T15845 in the process

I imported ~20 Catalan and Danish translations from libphutil where the hex part of the message key was changes and the content was slightly reformatted on the translatewiki.net side, marking them as FUZZY. There were also some Turkish translations I chose not to import because they were by BaRaN6161TURK since and the quality of BaRaN6161TURK's translations is dubious (https://translatewiki.net/wiki/Thread:Support/Some_Turkish_users_use_Google_Translate).

The Gerrit patch above handles the cases where the hex part of the message key hasn't changed, which should resolve this task.

Pppery removed a project: Patch-For-Review.

https://gerrit.wikimedia.org/r/c/phabricator/translations/+/1037902 was merged (I seem to have accidentally deleted the bug number at some point) thus resolving.

Post-close note: the above only worked for languages that met the old export threshold of 25%. Languages that did not meet that threshold were never committed to the repo, and this I never saw them. There are 1,718 of those (https://translatewiki.net/w/i.php?title=Special:Search&limit=500&offset=500&ns1274=1&search=libphutil-core+-intitle%3Aen+-intitle%3Aqqq+-intitle%3Afr+-intitle%3Ada+-intitle%3Atr+-intitle%3Aca) , and it's unlikely I'll do anything with them.

Especially since it seems like a decent fraction are test case messages or already translated.

Change #1039341 had a related patch set uploaded (by Pppery; author: Pppery):

[phabricator/translations@wmf/stable] Rescue libphutil translations (languages below export threshold)

https://gerrit.wikimedia.org/r/1039341

Apparently I was bored enough to do this.

Change #1039341 merged by Aklapper:

[phabricator/translations@wmf/stable] Rescue libphutil translations (languages below old export threshold)

https://gerrit.wikimedia.org/r/1039341