1.43.0-wmf.13 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Assigned To

Authored By

	thcipriani
	Jun 7 2024, 10:21 PM

Details

Backup Train Conductor: hashar
Release Version: 1.43.0-wmf.13
Release Date: Jul 8 2024, 12:00 AM

2024 week 28 1.43-wmf.13 Changes wmf/1.43.0-wmf.13

This MediaWiki Train Deployment is scheduled for the week of Monday, July 8th:

Monday July 8th	Tuesday, July 9th	Wednesday, July 10th	Thursday, July 11th	Friday
Backports only.	Branch `wmf.13` and deploy to Group 0 Wikis.	Deploy `wmf.13` to Group 1 Wikis.	Deploy `wmf.13` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.13 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.43.0-wmf.12

Next: 1.43.0-wmf.14

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
group2 wikis to 1.43.0-wmf.13	operations/mediawiki-config	master	+338 -338
group1 wikis to 1.43.0-wmf.13	operations/mediawiki-config	master	+556 -556
group0 wikis to 1.43.0-wmf.13	operations/mediawiki-config	master	+132 -132
testwikis wikis to 1.43.0-wmf.13	operations/mediawiki-config	master	+3 -3
Branch commit for wmf/1.43.0-wmf.13	mediawiki/core	wmf/1.43.0-wmf.13	+1 K -3

Customize query in gerrit

Related Objects

Mentioned In: T369689: scap train should not abort when train task status is "progress" instead of "open"
T369568: Duplicating an EditEngine form does not log its creation
T369310: CTT tasks week of 2024-07-05
T368687: Verify 1.43.0-wmf.13 deployment

Event Timeline

thcipriani created this task.Jun 7 2024, 10:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2024, 10:21 PM

Jdlrobson mentioned this in T368687: Verify 1.43.0-wmf.13 deployment.Jun 27 2024, 11:06 PM

thcipriani assigned this task to Aklapper.Jun 28 2024, 9:05 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: hashar.

thcipriani set the point value for this task to 5.

thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).

ihurbain mentioned this in T369310: CTT tasks week of 2024-07-05.Jul 4 2024, 4:40 PM

Risky Patch! 🚂🔥

Change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TextExtracts/+/1048086 ApiQueryExtracts: Replace custom parsing logic with ParserOutputAccess
Summary:
- This commit changes a heavily-used action API endpoint to use the new(ish) ParserOutputAccess interface, potentially making it write to the parser cache when it previously could only read from it.
- On cache misses, the module will do more CPU work now, parsing whole pages when it previously only parsed fragments (but due to the above, cache misses should be less common).
Test plan:
- Smoke test: https://en.wikipedia.org/w/api.php?action=query&prop=extracts&exintro&explaintext&titles=Wikipedia (it has its own cache, so this may not reveal issues)
- The API endpoint is not used by any of our own code (AFAIK), only third-parties, so it's not very obviously testable.
Places to monitor:
- https://grafana.wikimedia.org/d/000000002/mediawiki-action-api-summary?orgId=1&refresh=5m&var-type=api_query (watch for increases in extracts load)
- https://grafana.wikimedia.org/d/000000106/parser-cache?orgId=1 (disk usage and latency)
Revert plan: Revert patch
Affected wikis: all
IRC contact: MatmaRex, Krinkle
UBN Task Projects/tags: TextExtracts (please CC me, the extension is unmaintained) – Content-Transform-Team are the experts, but this work isn't their fault :)
Would you like to backport this change rather than ride the train?: No

Aklapper mentioned this in T369568: Duplicating an EditEngine form does not log its creation.Jul 8 2024, 10:53 PM

Change #1052835 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.43.0-wmf.13] Branch commit for wmf/1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052835

gerritbot added a project: Patch-For-Review.Jul 9 2024, 1:08 AM

Change #1052835 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.13] Branch commit for wmf/1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052835

Change #1052838 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052838

Change #1052838 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052838

Mentioned in SAL (#wikimedia-operations) [2024-07-09T03:02:59Z] <mwpresync@deploy1002> Started scap sync-world: testwikis wikis to 1.43.0-wmf.13 refs T366958

Mentioned in SAL (#wikimedia-operations) [2024-07-09T03:53:51Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.43.0-wmf.13 refs T366958 (duration: 50m 52s)

Change #1052910 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052910

Change #1052910 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1052910

Mentioned in SAL (#wikimedia-operations) [2024-07-09T08:17:25Z] <aklapper@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.43.0-wmf.13 refs T366958

Aklapper changed the task status from Open to In Progress.Jul 9 2024, 8:57 AM

hashar subscribed.Jul 9 2024, 9:38 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 7:58 PM

Aklapper changed the task status from In Progress to Open.Jul 10 2024, 8:15 AM

Aklapper mentioned this in T369689: scap train should not abort when train task status is "progress" instead of "open".Jul 10 2024, 8:41 AM

Change #1053250 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1053250

Change #1053250 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1053250

Mentioned in SAL (#wikimedia-operations) [2024-07-10T08:51:05Z] <aklapper@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.43.0-wmf.13 refs T366958

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2024, 9:31 AM

@Aklapper the issue we had this morning with scap train rejecting the deployment has been solved:

$ curl -s https://train-blockers.toolforge.org/api.php|jq .current.status
"open"

success

So I guess tomorrow will be easier.

Change #1053615 had a related patch set uploaded (by TrainBranchBot; author: Andre Klapper):

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1053615

Change #1053615 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.43.0-wmf.13

https://gerrit.wikimedia.org/r/1053615

Mentioned in SAL (#wikimedia-operations) [2024-07-11T08:15:04Z] <aklapper@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.43.0-wmf.13 refs T366958

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 8:31 AM

We fine, it seems.

1.43.0-wmf.13 deployment blockersClosed, ResolvedPublic5 Estimated Story PointsReleaseActions