Page MenuHomePhabricator

Explore displaying additional info in comment field for open Outreach related tasks
Open, Stalled, LowPublicFeature

Description

It seems hard for new community members to understand which topics to bring up as a comment in a task and when in Zulip etc, so I'd like to experiment with displaying some placeholder text in the comment field (as you may not always spot or read a red box on top of a task description anyway - which might be forgotten to be added anywayanyway).

Maniphest task comment field placeholder text proposal:

This Phabricator task is part of an Outreach program. As an applicant, first fully read https://www.mediawiki.org/wiki/Outreachy/Participants and https://www.mediawiki.org/wiki/New_Developers/Communication_tips. Use the Zulip Chatstream to introduce yourself and connect with fellow participants. Use Zulip to ask general questions how to get started, setting up Gerrit, program rules, etc. Phabricator is only for project-related discussions; it is not for general support or chatting. Thanks.

Event Timeline

Aklapper changed the task status from Open to Stalled.Fri, Jun 14, 12:12 PM
Aklapper claimed this task.
Aklapper triaged this task as Low priority.
Aklapper created this task.

This piggybackrides on the code needed to implement T354769: Display warning about commenting on a task already closed as duplicate in upstream, thus setting status to stalled for the time being.

Code to add in ManiphestEditEngine.php:

// WMF BEGIN custom Outreach task comment placeholder
    if (ManiphestTaskStatus::isOpenStatus($task->getStatus())) {
      $outreach_parent_projects[] = array('PHID-PROJ-rmphcfxf3ptf6ycqb4ig',
        'PHID-PROJ-xog5wkpbqzbz7bcuazpg'); // Outreach and GSoC parent projects
      $outreach_subprojects = id(new PhabricatorProjectQuery())
        ->setViewer($viewer)
        ->withAncestorProjectPHIDs($outreach_parent_projects)
        ->withStatuses(array(PhabricatorProjectStatus::STATUS_ACTIVE))
        ->execute();
      $outreach_subpphids = array();
      foreach ($outreach_subprojects as $osp) {
        $outreach_subpphids[] = $osp->getPHID();
      }
      $task_pphids = $task->getProjectPHIDs();
      if ($task_pphids && (bool)array_intersect($task_pphids, $outreach_subpphids)) {
        return pht('This is an open task tagged with an Outreach subproject!');
      }
    }
// WMF END custom Outreach task comment placeholder

Heads-up to @Maryann-Onyinye when it comes to drafting the placeholder plaintext to display by default in the task comment field in Phabricator for open Outreach program tasks (and whether this idea makes sense at all)

Example repeatedly posted last time: https://phabricator.wikimedia.org/T357409#9599197 and the red box at the top of the task description.