Page MenuHomePhabricator

Audit members of acl*security for more than 12 months of no activity (May 2025)
Closed, ResolvedPublic

Description

Previous tasks: T337305, T301181, T299400, T241781.
(Filing this task as individual non-public calendars are not a task tracking system.)

  1. Go to https://phabricator.wikimedia.org/conduit/method/project.query/ and query for phids = ["PHID-PROJ-koo4qqdng27q7r65x3cw"]
  2. Use the results in the members array to feed the phids into the SQL query: SELECT DISTINCT(CONCAT("https://phabricator.wikimedia.org/p/", userName)), isDisabled FROM phabricator_user.user WHERE phid NOT IN (SELECT trs.authorPHID FROM phabricator_maniphest.maniphest_transaction trs INNER JOIN phabricator_user.user u WHERE FROM_UNIXTIME(trs.dateModified) >= (NOW() - INTERVAL 1 YEAR) AND trs.authorPHID = u.phid) AND (phid = "PHID-USER-..." OR phid = "PHID-USER-...");
  3. Review the user names
  4. Once done, create a new task for the next review, and resolve this task.

Alternatively, for those with production DB access, another option is to run:
SELECT DISTINCT(CONCAT("https://phabricator.wikimedia.org/p/", usr.userName)) AS user, usr.isSystemAgent AS isBot FROM phabricator_user.user usr WHERE usr.isDisabled = 0 AND usr.phid IN (SELECT e.src FROM phabricator_user.edge e WHERE e.dst = "PHID-PROJ-koo4qqdng27q7r65x3cw" AND e.type = 14 AND FROM_UNIXTIME(e.dateCreated) <= (NOW() - INTERVAL 12 MONTH)) AND usr.phid NOT IN (SELECT trs.authorPHID FROM phabricator_maniphest.maniphest_transaction trs INNER JOIN phabricator_user.user u WHERE FROM_UNIXTIME(trs.dateModified) >= (NOW() - INTERVAL 12 MONTH) AND trs.authorPHID = u.phid);

Details

Due Date
Jun 30 2025, 10:00 PM

Event Timeline

Aklapper changed the task status from Open to Stalled.
Aklapper triaged this task as Low priority.
Aklapper moved this task from To Triage to External on the Phabricator board.

Stalled on completion date. If that's not proper, we can set the status to something else. The Security-Team also has a calendar invite set for this next year.

Aklapper changed the task status from Stalled to Open.May 25 2025, 10:10 AM

It's that time of the year.

Aklapper changed Due Date from Apr 30 2025, 10:00 PM to Jun 30 2025, 10:00 PM.May 25 2025, 10:11 AM

@Aklapper would you be able to provide a list of those users, as I do not have DB access. I am happy to follow up with a task for it, similar to the work done in WMF-NDA.

@Jly: Posted the SQL query results in non-public P76908. Could just (re)use this task?

Thanks! I will take a look at it and get back to you soon.

sbassett changed the task status from Open to In Progress.Jun 9 2025, 4:30 PM
sbassett added a project: SecTeam-Processed.
sbassett moved this task from Incoming to In Progress on the Security-Team board.

I've posted the results in P76908, and we will proceed with the removals sometime this week

I've posted the results in P76908, and we will proceed with the removals sometime this week

Mind adding me to see P76908, please?

I've completed the audit in P76908 and the current users are either active stewards, WMF and WMDE staff.

@Jly: Hi, see bullet point 4 in the task description

My apologies. T397734 has been opened and I will proceed to close this one now. Thanks all.