In T365675#9855435, @bd808 wrote:In T365675#9854875, @brennen wrote:The only thing I noticed was Offset pagination for /users REST API endpoint is deprecated. I wondered if this would hit gitlab-settings/group-management, but it looks to me based on the keyset-based pagination docs that it's already fine.
@bd808 might be worth a glance at whether the account approval bot is hit by that one?
Is there a v17 server that things can be tested against? The relevant gitlab-account-approval code does look like it may need updating to fit with https://docs.gitlab.com/ee/api/rest/index.html#keyset-based-pagination. Pretty weird that they would drop the default pagination method there without making the new method the default, but trying to understand the upstream reasoning can often be tricky.
Description
Description
Related Objects
Related Objects
- Mentioned Here
- T365675: Upgrade GitLab to major version 17