Page MenuHomePhabricator

Switch to keyset based pagination
Open, Needs TriagePublic

Description

The only thing I noticed was Offset pagination for /users REST API endpoint is deprecated. I wondered if this would hit gitlab-settings/group-management, but it looks to me based on the keyset-based pagination docs that it's already fine.

@bd808 might be worth a glance at whether the account approval bot is hit by that one?

Is there a v17 server that things can be tested against? The relevant gitlab-account-approval code does look like it may need updating to fit with https://docs.gitlab.com/ee/api/rest/index.html#keyset-based-pagination. Pretty weird that they would drop the default pagination method there without making the new method the default, but trying to understand the upstream reasoning can often be tricky.