Page MenuHomePhabricator

Interface message Recentchanges-legend-plusminus shouldn't use HTML tag <em>
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Go to [[Special:RecentChanges]] on a wiki with the default [[MediaWiki:Recentchanges-legend-plusminus]] and where there are recent changes to be seen
  2. Look at the legend on the right ("List of abbreviations"), particularly the line "The page size changed by this number of bytes"
  3. Look at the byte change difference in any of the edits
  4. Compare the formatting of the numbers from steps 2 and 3.

What happens?:

  • The number from step 2 is formatted using HTML tag <em>
    Screenshot_20240827.png (602×1 px, 191 KB)

What should have happened instead?:

  • The number from step 2 shouldn't be wrapped in <em> for visual consistency with the actual GUI from step 3.

Other information (browser name/version, screenshots, etc.):

  • Same issue applies to [[Special:Watchlist]], if the watchlist is populated, etc.
  • Git history of the interface message rc-change-size and its usage in file includes/changes/ChangesList.php seem to suggest that the actual UI element was never wrapped in <em>
    • Regular <span> was introduced in commit 75313380808 ("* DB schema change: added two columns (rc_old_len and rc_new_len) to the recentchanges table to store the text lengths before and after the edit * (bug 1085) Made Special:Recentchanges show the character difference between the changed revisions", 2006-12-09)
    • <strong> was introduced in commit 3d8659162d5 ("* Fix typos in new class names (thanks to BrokenArrow) * Use <strong class="mw-plusminus-neg">, not <span class="mw-plusminus-bold"> * Add correct coloring for null edits to non-Monobook-based skins", 2006-12-20)
  • Originally noticed at https://en.wikipedia.org/wiki/MediaWiki_talk:Recentchanges-legend-plusminus
  • As far as I understand, for most languages, the localized messages need to be changed on https://translatewiki.net/. Here are two patches: for the English version and for all affected locales:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1066959 had a related patch set uploaded (by Pppery; author: Andrei Rybak):

[mediawiki/core@master] remove <em> from recentchanges-legend-plusminus

https://gerrit.wikimedia.org/r/1066959

Your understanding about how the process works is correct - the en.json file is generally changed through Gerrit, and other languages are changed through translatewiki.net. I added the patch you supplied to Gerrit for review.

Change #1066959 merged by jenkins-bot:

[mediawiki/core@master] remove <em> from recentchanges-legend-plusminus

https://gerrit.wikimedia.org/r/1066959