Foundation logo overlapping monthly convert modal in smaller screen sizes
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	Cstone
	Sep 5 2024, 1:15 AM

Description

Found in testing of T371523: Implement Post-Payment Monthly Convert variant for testing

From @spatton:

I'll note one visual issue where the WMF logo comes through the white background of the mc-modal container.

Screenshot 2024-08-30 at 12.12.20 PM.png (1×1 px, 161 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Foundation logo overlapping monthly convert modal in smaller screen sizes	mediawiki/extensions/DonationInterface	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned In: T371523: Implement Post-Payment Monthly Convert variant for testing
Mentioned Here: T371523: Implement Post-Payment Monthly Convert variant for testing

Event Timeline

Cstone created this task.Sep 5 2024, 1:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2024, 1:15 AM

Cstone mentioned this in T371523: Implement Post-Payment Monthly Convert variant for testing .Sep 5 2024, 1:15 AM

AKanji-WMF moved this task from Triage to Chaos Holding Pen on the Fundraising-Backlog board.Sep 5 2024, 5:03 PM

@spatton asked me to take a look at this issue. The simplest fix is to move the modal HTML to the bottom of the document. This will fix the issue because the WMF logo has a position of static which means it will stack on top of any elements that appear before it in the HTML.

If that's not possible, let me know and we can look for another solution.

AnnWF claimed this task.Thu, Oct 10, 9:30 PM

AnnWF added a project: Fundraising Tech - Chaos Crew.

AnnWF moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.

Change #1079367 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Foundation logo overlapping monthly convert modal in smaller screen sizes

https://gerrit.wikimedia.org/r/1079367

gerritbot added a project: Patch-For-Review.Thu, Oct 10, 10:44 PM

AnnWF moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.Thu, Oct 10, 10:46 PM

Change #1079367 merged by jenkins-bot: