Maniphest T377145

PhanTypeMismatchArgumentNullableInternal
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Oct 14 2024, 2:41 PM

Tags

Referenced Files

None

Subscribers

Description

Seen on an unrelated patch

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/1078749
https://integration.wikimedia.org/ci/job/mwext-php74-phan/46699/console

15:38:49 includes/SpecialLintErrors.php:213 PhanTypeMismatchArgumentNullableInternal Argument 1 ($string) is $namespaceRequestValues of type ?string but \strlen() takes string (expected type to be non-nullable)
15:38:49 includes/SpecialLintErrors.php:214 PhanTypeMismatchArgumentNullableInternal Argument 2 ($string) is $namespaceRequestValues of type ?string but \explode() takes string (expected type to be non-nullable)

Seemingly broken by rMW7be5a303d162: WebRequest: Add PHP return type hint for getRawVal

Details

	Subject	Repo	Branch	Lines +/-
	SpecialLintErrors: Fix phan failure due to MW core change	mediawiki/extensions/Linter	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: rMW7be5a303d162: WebRequest: Add PHP return type hint for getRawVal

Event Timeline

Reedy created this task.Oct 14 2024, 2:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2024, 2:41 PM

Change #1080049 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Linter@master] SpecialLintErrors: Fix phan failure due to MW core change

https://gerrit.wikimedia.org/r/1080049

gerritbot added a project: Patch-For-Review.Oct 14 2024, 2:43 PM

Change #1080049 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] SpecialLintErrors: Fix phan failure due to MW core change

https://gerrit.wikimedia.org/r/1080049

Reedy closed this task as Resolved.Oct 14 2024, 3:04 PM

Reedy claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2024, 3:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15).Oct 14 2024, 4:00 PM